iio: si1133: fix format string warnings
authorArnd Bergmann <arnd@arndb.de>
Thu, 3 Jun 2021 18:06:09 +0000 (19:06 +0100)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Wed, 9 Jun 2021 17:31:03 +0000 (18:31 +0100)
clang complains about multiple instances of printing an integer
using the %hhx format string:

drivers/iio/light/si1133.c:982:4: error: format specifies type 'unsigned char' but the argument has type 'unsigned int' [-Werror,-Wformat]
                 part_id, rev_id, mfr_id);
                 ^~~~~~~

Print them as a normal integer instead, leaving the "#02"
length modifier.

Use the 0x02x form as the length specifier when used with # includes
the 0x prefix and is very unlikely to be what was intended by the author.

Fixes: e01e7eaf37d8 ("iio: light: introduce si1133")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Link: https://lore.kernel.org/r/20210603180612.3635250-2-jic23@kernel.org
drivers/iio/light/si1133.c

index c280b41950036a57b32db6a75e7acae81fb7eb68..0accea7090eeb4d5e2e4d4aada1247623fb4c806 100644 (file)
@@ -978,11 +978,11 @@ static int si1133_validate_ids(struct iio_dev *iio_dev)
                return err;
 
        dev_info(&iio_dev->dev,
-                "Device ID part %#02hhx rev %#02hhx mfr %#02hhx\n",
+                "Device ID part 0x%02x rev 0x%02x mfr 0x%02x\n",
                 part_id, rev_id, mfr_id);
        if (part_id != SI1133_PART_ID) {
                dev_err(&iio_dev->dev,
-                       "Part ID mismatch got %#02hhx, expected %#02x\n",
+                       "Part ID mismatch got 0x%02x, expected 0x%02x\n",
                        part_id, SI1133_PART_ID);
                return -ENODEV;
        }