iio: frequency: admv1013: Benefit from devm_clk_get_enabled() to simplify

Make use of devm_clk_get_enabled() to replace some code that effectively
open codes this new function.

To retain ordering move the request to a place that is executed later.
This way the time of enable keeps the same.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230313185333.2776785-1-u.kleine-koenig@pengutronix.de
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

diff --git a/drivers/iio/frequency/admv1013.c b/drivers/iio/frequency/admv1013.c
index ed81672..9bf8337 100644 (file)
--- a/drivers/iio/frequency/admv1013.c
+++ b/drivers/iio/frequency/admv1013.c
@@ -490,11 +490,6 @@ static int admv1013_init(struct admv1013_state *st)
                                          st->input_mode);
 }
 
-static void admv1013_clk_disable(void *data)
-{
-       clk_disable_unprepare(data);
-}
-
 static void admv1013_reg_disable(void *data)
 {
        regulator_disable(data);
@@ -559,11 +554,6 @@ static int admv1013_properties_parse(struct admv1013_state *st)
                return dev_err_probe(&spi->dev, PTR_ERR(st->reg),
                                     "failed to get the common-mode voltage\n");
 
-       st->clkin = devm_clk_get(&spi->dev, "lo_in");
-       if (IS_ERR(st->clkin))
-               return dev_err_probe(&spi->dev, PTR_ERR(st->clkin),
-                                    "failed to get the LO input clock\n");
-
        return 0;
 }
 
@@ -601,13 +591,10 @@ static int admv1013_probe(struct spi_device *spi)
        if (ret)
                return ret;
 
-       ret = clk_prepare_enable(st->clkin);
-       if (ret)
-               return ret;
-
-       ret = devm_add_action_or_reset(&spi->dev, admv1013_clk_disable, st->clkin);
-       if (ret)
-               return ret;
+       st->clkin = devm_clk_get_enabled(&spi->dev, "lo_in");
+       if (IS_ERR(st->clkin))
+               return dev_err_probe(&spi->dev, PTR_ERR(st->clkin),
+                                    "failed to get the LO input clock\n");
 
        st->nb.notifier_call = admv1013_freq_change;
        ret = devm_clk_notifier_register(&spi->dev, st->clkin, &st->nb);