staging: lustre: lmv: Use !x to check for kzalloc failure
authorJulia Lawall <Julia.Lawall@lip6.fr>
Sat, 20 Jun 2015 16:59:03 +0000 (18:59 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 14 Jul 2015 02:35:52 +0000 (19:35 -0700)
!x is more normal for kzalloc failure in the kernel.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression x;
statement S1, S2;
@@

x = kzalloc(...);
if (
- x == NULL
+ !x
 ) S1 else S2
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/lustre/lustre/lmv/lmv_intent.c
drivers/staging/lustre/lustre/lmv/lmv_obd.c

index cb35f63..eebe45b 100644 (file)
@@ -100,7 +100,7 @@ static int lmv_intent_remote(struct obd_export *exp, void *lmm,
        }
 
        op_data = kzalloc(sizeof(*op_data), GFP_NOFS);
-       if (op_data == NULL) {
+       if (!op_data) {
                rc = -ENOMEM;
                goto out;
        }
index ac5053c..5c058d0 100644 (file)
@@ -716,7 +716,7 @@ repeat_fid2path:
        if (remote_gf == NULL) {
                remote_gf_size = sizeof(*remote_gf) + PATH_MAX;
                remote_gf = kzalloc(remote_gf_size, GFP_NOFS);
-               if (remote_gf == NULL) {
+               if (!remote_gf) {
                        rc = -ENOMEM;
                        goto out_fid2path;
                }
@@ -1398,7 +1398,7 @@ static int lmv_statfs(const struct lu_env *env, struct obd_export *exp,
                return rc;
 
        temp = kzalloc(sizeof(*temp), GFP_NOFS);
-       if (temp == NULL)
+       if (!temp)
                return -ENOMEM;
 
        for (i = 0; i < lmv->desc.ld_tgt_count; i++) {
@@ -1730,7 +1730,7 @@ lmv_enqueue_remote(struct obd_export *exp, struct ldlm_enqueue_info *einfo,
        }
 
        rdata = kzalloc(sizeof(*rdata), GFP_NOFS);
-       if (rdata == NULL) {
+       if (!rdata) {
                rc = -ENOMEM;
                goto out;
        }