projects
/
platform
/
kernel
/
linux-starfive.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
c5a6776
)
PCI: Check for alloc failure in pci_request_irq()
author
Zeng Heng
<zengheng4@huawei.com>
Mon, 21 Nov 2022 02:00:29 +0000
(10:00 +0800)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Sat, 31 Dec 2022 12:32:33 +0000
(13:32 +0100)
[ Upstream commit
2d9cd957d40c3ac491b358e7cff0515bb07a3a9c
]
When kvasprintf() fails to allocate memory, it returns a NULL pointer.
Return error from pci_request_irq() so we don't dereference it.
[bhelgaas: commit log]
Fixes:
704e8953d3e9
("PCI/irq: Add pci_request_irq() and pci_free_irq() helpers")
Link:
https://lore.kernel.org/r/20221121020029.3759444-1-zengheng4@huawei.com
Signed-off-by: Zeng Heng <zengheng4@huawei.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/pci/irq.c
patch
|
blob
|
history
diff --git
a/drivers/pci/irq.c
b/drivers/pci/irq.c
index
12ecd0a
..
0050e8f
100644
(file)
--- a/
drivers/pci/irq.c
+++ b/
drivers/pci/irq.c
@@
-44,6
+44,8
@@
int pci_request_irq(struct pci_dev *dev, unsigned int nr, irq_handler_t handler,
va_start(ap, fmt);
devname = kvasprintf(GFP_KERNEL, fmt, ap);
va_end(ap);
+ if (!devname)
+ return -ENOMEM;
ret = request_threaded_irq(pci_irq_vector(dev, nr), handler, thread_fn,
irqflags, devname, dev_id);