nvmet: remove a duplicate status assignment in nvmet_alloc_ctrl
authorChaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Thu, 25 Feb 2021 01:56:37 +0000 (17:56 -0800)
committerChristoph Hellwig <hch@lst.de>
Fri, 2 Apr 2021 16:48:25 +0000 (18:48 +0200)
In the function nvmet_alloc_ctrl() we assign status value before we
call nvmet_fine_get_subsys() to:

status = NVME_SC_CONNECT_INVALID_PARAM | NVME_SC_DNR;

After we successfully find the subsystem we again set the status value
to:

status = NVME_SC_CONNECT_INVALID_PARAM | NVME_SC_DNR;

Remove the duplicate status assignment value.

Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/nvme/target/core.c

index be6fcda..e3b8ec5 100644 (file)
@@ -1314,7 +1314,6 @@ u16 nvmet_alloc_ctrl(const char *subsysnqn, const char *hostnqn,
                goto out;
        }
 
-       status = NVME_SC_CONNECT_INVALID_PARAM | NVME_SC_DNR;
        down_read(&nvmet_config_sem);
        if (!nvmet_host_allowed(subsys, hostnqn)) {
                pr_info("connect by host %s for subsystem %s not allowed\n",