PCI: kirin: Add power_off support for Kirin 960 PHY

In order to prepare for module unload, add a power_off method for HiKey
960.

Link: https://lore.kernel.org/r/b095818b0d7fadae4cae200f481caf7a66e61fb4.1634812676.git.mchehab+huawei@kernel.org
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Xiaowei Song <songxiaowei@hisilicon.com>

diff --git a/drivers/pci/controller/dwc/pcie-kirin.c b/drivers/pci/controller/dwc/pcie-kirin.c
index 66e3aefcb8177d1e8c1b571508f7e89ab26b2d86..6c9fb3f219ba4aebcea443a44824e89a4961dc8c 100644 (file)
--- a/drivers/pci/controller/dwc/pcie-kirin.c
+++ b/drivers/pci/controller/dwc/pcie-kirin.c
@@ -342,6 +342,18 @@ static int hi3660_pcie_phy_init(struct platform_device *pdev,
        return hi3660_pcie_phy_get_resource(phy);
 }
 
+static int hi3660_pcie_phy_power_off(struct kirin_pcie *pcie)
+{
+       struct hi3660_pcie_phy *phy = pcie->phy_priv;
+
+       /* Drop power supply for Host */
+       regmap_write(phy->sysctrl, SCTRL_PCIE_CMOS_OFFSET, 0x00);
+
+       hi3660_pcie_phy_clk_ctrl(phy, false);
+
+       return 0;
+}
+
 /*
  * The non-PHY part starts here
  */
@@ -561,7 +573,6 @@ static int kirin_pcie_add_bus(struct pci_bus *bus)
        return 0;
 }
 
-
 static struct pci_ops kirin_pci_ops = {
        .read = kirin_pcie_rd_own_conf,
        .write = kirin_pcie_wr_own_conf,
@@ -715,8 +726,12 @@ static int kirin_pcie_power_on(struct platform_device *pdev,
 
        return 0;
 err:
-       if (kirin_pcie->type != PCIE_KIRIN_INTERNAL_PHY)
+       if (kirin_pcie->type == PCIE_KIRIN_INTERNAL_PHY) {
+               hi3660_pcie_phy_power_off(kirin_pcie);
+       } else {
+               phy_power_off(kirin_pcie->phy);
                phy_exit(kirin_pcie->phy);
+       }
 
        return ret;
 }
@@ -726,7 +741,7 @@ static int __exit kirin_pcie_remove(struct platform_device *pdev)
        struct kirin_pcie *kirin_pcie = platform_get_drvdata(pdev);
 
        if (kirin_pcie->type == PCIE_KIRIN_INTERNAL_PHY)
-               return 0;
+               return hi3660_pcie_phy_power_off(kirin_pcie);
 
        phy_power_off(kirin_pcie->phy);
        phy_exit(kirin_pcie->phy);