fbdev/fsl-diu-fb: Remove flag FBINFO_DEFAULT
authorThomas Zimmermann <tzimmermann@suse.de>
Sat, 15 Jul 2023 18:51:48 +0000 (20:51 +0200)
committerThomas Zimmermann <tzimmermann@suse.de>
Mon, 24 Jul 2023 14:50:38 +0000 (16:50 +0200)
The flag FBINFO_DEFAULT is 0 and has no effect, as struct fbinfo.flags
has been allocated to zero by dmam_alloc_coherent(__GFP_ZERO). So do not
set it.

Flags should signal differences from the default values. After cleaning
up all occurrences of FBINFO_DEFAULT, the token will be removed.

v2:
* fix commit message (Miguel)

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Timur Tabi <timur@kernel.org>
Cc: Helge Deller <deller@gmx.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20230715185343.7193-7-tzimmermann@suse.de
drivers/video/fbdev/fsl-diu-fb.c

index 785eb8a..c62b48f 100644 (file)
@@ -1476,7 +1476,7 @@ static int install_fb(struct fb_info *info)
 
        info->var.activate = FB_ACTIVATE_NOW;
        info->fbops = &fsl_diu_ops;
-       info->flags = FBINFO_DEFAULT | FBINFO_VIRTFB | FBINFO_PARTIAL_PAN_OK |
+       info->flags = FBINFO_VIRTFB | FBINFO_PARTIAL_PAN_OK |
                FBINFO_READS_FAST;
        info->pseudo_palette = mfbi->pseudo_palette;