GSocks5Proxy: don't crash if parsing negotiation reply fails

The GError should be initialized to NULL, otherwise we'll
"pile up" errors, then try to free an uninitialized pointer.

Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=699493

diff --git a/gio/gsocks5proxy.c b/gio/gsocks5proxy.c
index 9d9055f..0d6269e 100644 (file)
--- a/gio/gsocks5proxy.c
+++ b/gio/gsocks5proxy.c
@@ -708,7 +708,7 @@ nego_reply_read_cb (GObject      *source,
   
   if (data->offset == data->length)
     {
-      GError *error;
+      GError *error = NULL;
       gboolean must_auth = FALSE;
       gboolean has_auth = data->username || data->password;