usb: dwc2: gadget: Remove assigned but never used 'maxsize'
authorLee Jones <lee.jones@linaro.org>
Thu, 2 Jul 2020 14:46:05 +0000 (15:46 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 3 Jul 2020 08:20:11 +0000 (10:20 +0200)
The value of 'maxsize' has not been checked since commit 729cac693eecf
("usb: dwc2: Change ISOC DDMA flow") back in 2018, so remove the set but
unused variable, which fixes the following W=1 kernel build warning:

 drivers/usb/dwc2/gadget.c: In function ‘dwc2_gadget_fill_isoc_desc’:
 drivers/usb/dwc2/gadget.c:885:6: warning: variable ‘maxsize’ set but not used [-Wunused-but-set-variable]
 885 | u32 maxsize = 0;
 | ^~~~~~~

Cc: Minas Harutyunyan <hminas@synopsys.com>
Cc: Ben Dooks <ben@simtec.co.uk>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Link: https://lore.kernel.org/r/20200702144625.2533530-11-lee.jones@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/dwc2/gadget.c

index 1def900..df5feda 100644 (file)
@@ -882,11 +882,10 @@ static int dwc2_gadget_fill_isoc_desc(struct dwc2_hsotg_ep *hs_ep,
        struct dwc2_dma_desc *desc;
        struct dwc2_hsotg *hsotg = hs_ep->parent;
        u32 index;
-       u32 maxsize = 0;
        u32 mask = 0;
        u8 pid = 0;
 
-       maxsize = dwc2_gadget_get_desc_params(hs_ep, &mask);
+       dwc2_gadget_get_desc_params(hs_ep, &mask);
 
        index = hs_ep->next_desc;
        desc = &hs_ep->desc_list[index];