selftests: xsk: Remove thread attribute
authorBjörn Töpel <bjorn.topel@intel.com>
Mon, 29 Mar 2021 22:43:14 +0000 (00:43 +0200)
committerAlexei Starovoitov <ast@kernel.org>
Tue, 30 Mar 2021 16:24:40 +0000 (09:24 -0700)
There is really no reason to have a non-default thread stack
size. Remove that.

Signed-off-by: Björn Töpel <bjorn.topel@intel.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Link: https://lore.kernel.org/bpf/20210329224316.17793-16-maciej.fijalkowski@intel.com
tools/testing/selftests/bpf/xdpxceiver.c
tools/testing/selftests/bpf/xdpxceiver.h

index 5c0d6db..ec09b8f 100644 (file)
@@ -764,8 +764,6 @@ static void thread_common_ops(struct ifobject *ifobject, void *bufs)
        int ctr = 0;
        int ret;
 
-       pthread_attr_setstacksize(&attr, THREAD_STACK);
-
        ifobject->ns_fd = switch_namespace(ifobject->nsname);
 
        if (test_type == TEST_TYPE_BPF_RES)
@@ -909,13 +907,10 @@ static void testapp_validate(void)
        bool bidi = test_type == TEST_TYPE_BIDI;
        bool bpf = test_type == TEST_TYPE_BPF_RES;
 
-       pthread_attr_init(&attr);
-       pthread_attr_setstacksize(&attr, THREAD_STACK);
-
        pthread_mutex_lock(&sync_mutex);
 
        /*Spawn RX thread */
-       pthread_create(&t0, &attr, ifdict_rx->func_ptr, ifdict_rx);
+       pthread_create(&t0, NULL, ifdict_rx->func_ptr, ifdict_rx);
 
        if (clock_gettime(CLOCK_REALTIME, &max_wait))
                exit_with_error(errno);
@@ -927,7 +922,7 @@ static void testapp_validate(void)
        pthread_mutex_unlock(&sync_mutex);
 
        /*Spawn TX thread */
-       pthread_create(&t1, &attr, ifdict_tx->func_ptr, ifdict_tx);
+       pthread_create(&t1, NULL, ifdict_tx->func_ptr, ifdict_tx);
 
        pthread_join(t1, NULL);
        pthread_join(t0, NULL);
index e431ecb..7886382 100644 (file)
@@ -37,7 +37,6 @@
 #define TMOUT_SEC (3)
 #define EOT (-1)
 #define USLEEP_MAX 200000
-#define THREAD_STACK 60000000
 #define SOCK_RECONF_CTR 10
 #define BATCH_SIZE 64
 #define POLL_TMOUT 1000
@@ -152,7 +151,6 @@ static struct ifobject *ifdict_tx;
 pthread_mutex_t sync_mutex;
 pthread_cond_t signal_rx_condition;
 pthread_t t0, t1;
-pthread_attr_t attr;
 
 TAILQ_HEAD(head_s, pkt) head = TAILQ_HEAD_INITIALIZER(head);
 struct head_s *head_p;