net: usb: remove redundant null pointer check before of_node_put
authorzhong jiang <zhongjiang@huawei.com>
Sun, 16 Sep 2018 13:20:17 +0000 (21:20 +0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 17 Sep 2018 15:20:11 +0000 (08:20 -0700)
of_node_put has taken the null pointer check into account. So it is
safe to remove the duplicated check before of_node_put.

Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/usb/lan78xx.c

index 95a98a2..04f0a09 100644 (file)
@@ -1835,8 +1835,7 @@ static int lan78xx_mdio_init(struct lan78xx_net *dev)
 
        node = of_get_child_by_name(dev->udev->dev.of_node, "mdio");
        ret = of_mdiobus_register(dev->mdiobus, node);
-       if (node)
-               of_node_put(node);
+       of_node_put(node);
        if (ret) {
                netdev_err(dev->net, "can't register MDIO bus\n");
                goto exit1;