staging: r8188eu: viq_cnt is write-only

viq_cnt in struct xmit_priv is initialised, incremented and decremented
but never read. Remove viq_cnt and resulting dead code.

Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Acked-by: Pavel Skripkin <paskripkin@gmail.com>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150
Link: https://lore.kernel.org/r/20230109212852.75612-4-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/r8188eu/core/rtw_xmit.c b/drivers/staging/r8188eu/core/rtw_xmit.c
index c06ab9b..031f094 100644 (file)
--- a/drivers/staging/r8188eu/core/rtw_xmit.c
+++ b/drivers/staging/r8188eu/core/rtw_xmit.c
@@ -195,7 +195,6 @@ int _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter)
        pxmitpriv->txirp_cnt = 1;
 
        /* per AC pending irp */
-       pxmitpriv->viq_cnt = 0;
        pxmitpriv->voq_cnt = 0;
 
        pxmitpriv->ack_tx = false;

diff --git a/drivers/staging/r8188eu/include/rtw_xmit.h b/drivers/staging/r8188eu/include/rtw_xmit.h
index 8defce2..71382f9 100644 (file)
--- a/drivers/staging/r8188eu/include/rtw_xmit.h
+++ b/drivers/staging/r8188eu/include/rtw_xmit.h
@@ -283,7 +283,6 @@ struct      xmit_priv {
        u8              txirp_cnt;/*  */
        struct tasklet_struct xmit_tasklet;
        /* per AC pending irp */
-       int viq_cnt;
        int voq_cnt;
        struct __queue free_xmitbuf_queue;
        struct __queue pending_xmitbuf_queue;

diff --git a/drivers/staging/r8188eu/os_dep/usb_ops_linux.c b/drivers/staging/r8188eu/os_dep/usb_ops_linux.c
index 5ae09ed..7929b7d 100644 (file)
--- a/drivers/staging/r8188eu/os_dep/usb_ops_linux.c
+++ b/drivers/staging/r8188eu/os_dep/usb_ops_linux.c
@@ -45,9 +45,6 @@ static void usb_write_port_complete(struct urb *purb, struct pt_regs *regs)
        case VO_QUEUE_INX:
                pxmitpriv->voq_cnt--;
                break;
-       case VI_QUEUE_INX:
-               pxmitpriv->viq_cnt--;
-               break;
        case HIGH_QUEUE_INX:
                rtw_chk_hi_queue_cmd(padapter);
                break;
@@ -113,7 +110,6 @@ u32 rtw_write_port(struct adapter *padapter, u32 addr, u32 cnt, u8 *wmem)
                pxmitbuf->flags = VO_QUEUE_INX;
                break;
        case VI_QUEUE_INX:
-               pxmitpriv->viq_cnt++;
                pxmitbuf->flags = VI_QUEUE_INX;
                break;
        case BE_QUEUE_INX: