net: macb: fix error format in dev_err()

commit f413cbb332a0b5251a790f396d0eb4ebcade5dec upstream.

Errors are negative numbers. Using %u shows them as very large positive
numbers such as 4294967277 that don't make sense. Use the %d format
instead, and get a much nicer -19.

Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
Fixes: b48e0bab142f ("net: macb: Migrate to devm clock interface")
Fixes: 93b31f48b3ba ("net/macb: unify clock management")
Fixes: 421d9df0628b ("net/macb: merge at91_ether driver into macb driver")
Fixes: aead88bd0e99 ("net: ethernet: macb: Add support for rx_clk")
Fixes: f5473d1d44e4 ("net: macb: Support clock management for tsu_clk")
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
index a0d6402..30e9304 100644 (file)
--- a/drivers/net/ethernet/cadence/macb.c
+++ b/drivers/net/ethernet/cadence/macb.c
@@ -2364,14 +2364,14 @@ static int macb_clk_init(struct platform_device *pdev, struct clk **pclk,
        *pclk = devm_clk_get(&pdev->dev, "pclk");
        if (IS_ERR(*pclk)) {
                err = PTR_ERR(*pclk);
-               dev_err(&pdev->dev, "failed to get macb_clk (%u)\n", err);
+               dev_err(&pdev->dev, "failed to get macb_clk (%d)\n", err);
                return err;
        }
 
        *hclk = devm_clk_get(&pdev->dev, "hclk");
        if (IS_ERR(*hclk)) {
                err = PTR_ERR(*hclk);
-               dev_err(&pdev->dev, "failed to get hclk (%u)\n", err);
+               dev_err(&pdev->dev, "failed to get hclk (%d)\n", err);
                return err;
        }
 
@@ -2385,25 +2385,25 @@ static int macb_clk_init(struct platform_device *pdev, struct clk **pclk,
 
        err = clk_prepare_enable(*pclk);
        if (err) {
-               dev_err(&pdev->dev, "failed to enable pclk (%u)\n", err);
+               dev_err(&pdev->dev, "failed to enable pclk (%d)\n", err);
                return err;
        }
 
        err = clk_prepare_enable(*hclk);
        if (err) {
-               dev_err(&pdev->dev, "failed to enable hclk (%u)\n", err);
+               dev_err(&pdev->dev, "failed to enable hclk (%d)\n", err);
                goto err_disable_pclk;
        }
 
        err = clk_prepare_enable(*tx_clk);
        if (err) {
-               dev_err(&pdev->dev, "failed to enable tx_clk (%u)\n", err);
+               dev_err(&pdev->dev, "failed to enable tx_clk (%d)\n", err);
                goto err_disable_hclk;
        }
 
        err = clk_prepare_enable(*rx_clk);
        if (err) {
-               dev_err(&pdev->dev, "failed to enable rx_clk (%u)\n", err);
+               dev_err(&pdev->dev, "failed to enable rx_clk (%d)\n", err);
                goto err_disable_txclk;
        }
 
@@ -2823,7 +2823,7 @@ static int at91ether_clk_init(struct platform_device *pdev, struct clk **pclk,
 
        err = clk_prepare_enable(*pclk);
        if (err) {
-               dev_err(&pdev->dev, "failed to enable pclk (%u)\n", err);
+               dev_err(&pdev->dev, "failed to enable pclk (%d)\n", err);
                return err;
        }