test: fix race condition in test-http-client-onerror

Occasionally test-http-client-onerror will fail with a refused connection.
This patch fixes the possibility that connections will be attempted before
server is listening.

PR-URL: https://github.com/nodejs/node/pull/4346
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>

diff --git a/test/gc/test-http-client-onerror.js b/test/gc/test-http-client-onerror.js
index 98d046e180f11baac684072aea0e4cb491da857e..7e50683c6633e5ff5393c25e158cdfe5c66f2efb 100644 (file)
--- a/test/gc/test-http-client-onerror.js
+++ b/test/gc/test-http-client-onerror.js
@@ -22,7 +22,7 @@ console.log('We should do ' + todo + ' requests');
 
 var http = require('http');
 var server = http.createServer(serverHandler);
-server.listen(PORT, getall);
+server.listen(PORT, runTest);
 
 function getall() {
   if (count >= todo)
@@ -51,8 +51,10 @@ function getall() {
   setImmediate(getall);
 }
 
-for (var i = 0; i < 10; i++)
-  getall();
+function runTest() {
+  for (var i = 0; i < 10; i++)
+    getall();
+}
 
 function afterGC() {
   countGC ++;