Driver: Fix think-o in adding -ivfsoverlay flag to crashdumps
authorJustin Bogner <mail@justinbogner.com>
Mon, 7 Jul 2014 17:34:40 +0000 (17:34 +0000)
committerJustin Bogner <mail@justinbogner.com>
Mon, 7 Jul 2014 17:34:40 +0000 (17:34 +0000)
If there isn't a VFS to overlay we shouldn't be adding a -ivfsoverlay
flag.

llvm-svn: 212468

clang/lib/Driver/Driver.cpp

index 08dcc11..2844033 100644 (file)
@@ -550,9 +550,11 @@ void Driver::generateCompilationDiagnostics(Compilation &C,
         E = I + OldFilename.size();
         I = Cmd.rfind(" ", I) + 1;
         Cmd.replace(I, E - I, NewFilename.data(), NewFilename.size());
-        // Add the VFS overlay to the reproduction script.
-        I += NewFilename.size();
-        Cmd.insert(I, std::string(" -ivfsoverlay ") + VFS.c_str());
+        if (!VFS.empty()) {
+          // Add the VFS overlay to the reproduction script.
+          I += NewFilename.size();
+          Cmd.insert(I, std::string(" -ivfsoverlay ") + VFS.c_str());
+        }
         ScriptOS << Cmd;
         Diag(clang::diag::note_drv_command_failed_diag_msg) << Script;
       }