net: phy: marvell: use positive logic for link state

Rather than using negative logic:

	if (there is no link)
		set link = 0
	else
		set link = 1

use the more natural positive logic:

	if (there is link)
		set link = 1
	else
		set link = 0

Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c
index b50c8a4..5900281 100644 (file)
--- a/drivers/net/phy/marvell.c
+++ b/drivers/net/phy/marvell.c
@@ -174,7 +174,6 @@
 #define ADVERTISE_PAUSE_FIBER          0x180
 #define ADVERTISE_PAUSE_ASYM_FIBER     0x100
 
-#define REGISTER_LINK_STATUS   0x400
 #define NB_FIBER_STATS 1
 
 MODULE_DESCRIPTION("Marvell PHY driver");
@@ -1327,10 +1326,10 @@ static int marvell_update_link(struct phy_device *phydev, int fiber)
                if (status < 0)
                        return status;
 
-               if ((status & REGISTER_LINK_STATUS) == 0)
-                       phydev->link = 0;
-               else
+               if (status & MII_M1011_PHY_STATUS_LINK)
                        phydev->link = 1;
+               else
+                       phydev->link = 0;
        } else {
                return genphy_update_link(phydev);
        }