drm/exynos: drop the use of label from exynos_dsi_register_te_irq
authorInki Dae <inki.dae@samsung.com>
Wed, 1 Dec 2021 02:32:14 +0000 (11:32 +0900)
committerInki Dae <inki.dae@samsung.com>
Wed, 22 Dec 2021 02:39:39 +0000 (11:39 +0900)
Dropped the use of 'out' label from exynos_dsi_register_te_irq function
because the label isn't needed. This patch returns an error in each
error case directly not going to 'out' label.

With this patch build warning[1] is also fixed, which was reported by
kernel test robot <lkp@intel.com>

[1] https://www.spinics.net/lists/dri-devel/msg323803.html

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Inki Dae <inki.dae@samsung.com>
drivers/gpu/drm/exynos/exynos_drm_dsi.c

index b0b1acb..32a3657 100644 (file)
@@ -1338,7 +1338,7 @@ static int exynos_dsi_register_te_irq(struct exynos_dsi *dsi,
        if (IS_ERR(dsi->te_gpio)) {
                dev_err(dsi->dev, "gpio request failed with %ld\n",
                                PTR_ERR(dsi->te_gpio));
-               goto out;
+               return PTR_ERR(dsi->te_gpio);
        }
 
        te_gpio_irq = gpiod_to_irq(dsi->te_gpio);
@@ -1348,11 +1348,10 @@ static int exynos_dsi_register_te_irq(struct exynos_dsi *dsi,
        if (ret) {
                dev_err(dsi->dev, "request interrupt failed with %d\n", ret);
                gpiod_put(dsi->te_gpio);
-               goto out;
+               return ret;
        }
 
-out:
-       return ret;
+       return 0;
 }
 
 static void exynos_dsi_unregister_te_irq(struct exynos_dsi *dsi)