drm/mgag200: set variable mgag200_modeset storage-class-specifier to static
authorTom Rix <trix@redhat.com>
Wed, 17 May 2023 13:41:40 +0000 (09:41 -0400)
committerJocelyn Falempe <jfalempe@redhat.com>
Fri, 23 Jun 2023 08:33:00 +0000 (10:33 +0200)
smatch reports
drivers/gpu/drm/mgag200/mgag200_drv.c:23:5: warning: symbol
  'mgag200_modeset' was not declared. Should it be static?

This variable is only used in its defining file, so it should be static

Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: Jocelyn Falempe <jfalempe@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230517134140.874179-1-trix@redhat.com
drivers/gpu/drm/mgag200/mgag200_drv.c

index 976f0ab..abddf37 100644 (file)
@@ -20,7 +20,7 @@
 
 #include "mgag200_drv.h"
 
-int mgag200_modeset = -1;
+static int mgag200_modeset = -1;
 MODULE_PARM_DESC(modeset, "Disable/Enable modesetting");
 module_param_named(modeset, mgag200_modeset, int, 0400);