regulator: virtual: use dev_err_probe()
authorVincent Whitchurch <vincent.whitchurch@axis.com>
Tue, 1 Mar 2022 11:18:29 +0000 (12:18 +0100)
committerMark Brown <broonie@kernel.org>
Wed, 2 Mar 2022 13:45:29 +0000 (13:45 +0000)
Use dev_err_probe() to avoid printing spurious warnings on
probe deferral.

Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com>
Link: https://lore.kernel.org/r/20220301111831.3742383-2-vincent.whitchurch@axis.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/virtual.c

index 52c5a0e..50d2e9c 100644 (file)
@@ -295,12 +295,10 @@ static int regulator_virtual_probe(struct platform_device *pdev)
        mutex_init(&drvdata->lock);
 
        drvdata->regulator = devm_regulator_get(&pdev->dev, reg_id);
-       if (IS_ERR(drvdata->regulator)) {
-               ret = PTR_ERR(drvdata->regulator);
-               dev_err(&pdev->dev, "Failed to obtain supply '%s': %d\n",
-                       reg_id, ret);
-               return ret;
-       }
+       if (IS_ERR(drvdata->regulator))
+               return dev_err_probe(&pdev->dev, PTR_ERR(drvdata->regulator),
+                                    "Failed to obtain supply '%s'\n",
+                                    reg_id);
 
        ret = sysfs_create_group(&pdev->dev.kobj,
                                 &regulator_virtual_attr_group);