mfd: twl-core: Remove unused add_child() and add_numbered_child() functions

Clang with W=1 reports:

  drivers/mfd/twl-core.c:654:30: error: unused function 'add_child' [-Werror,-Wunused-function]
  static inline struct device *add_child(unsigned mod_no, const char *name,
                               ^
add_numbered_child() and its only caller add_child() are not used, so remove them.

Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: Lee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20230322115838.2569414-1-trix@redhat.com

diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c
index e2d9a93..e801b7c 100644 (file)
--- a/drivers/mfd/twl-core.c
+++ b/drivers/mfd/twl-core.c
@@ -594,71 +594,6 @@ int twl_get_hfclk_rate(void)
 }
 EXPORT_SYMBOL_GPL(twl_get_hfclk_rate);
 
-static struct device *
-add_numbered_child(unsigned mod_no, const char *name, int num,
-               void *pdata, unsigned pdata_len,
-               bool can_wakeup, int irq0, int irq1)
-{
-       struct platform_device  *pdev;
-       struct twl_client       *twl;
-       int                     status, sid;
-
-       if (unlikely(mod_no >= twl_get_last_module())) {
-               pr_err("%s: invalid module number %d\n", DRIVER_NAME, mod_no);
-               return ERR_PTR(-EPERM);
-       }
-       sid = twl_priv->twl_map[mod_no].sid;
-       twl = &twl_priv->twl_modules[sid];
-
-       pdev = platform_device_alloc(name, num);
-       if (!pdev)
-               return ERR_PTR(-ENOMEM);
-
-       pdev->dev.parent = &twl->client->dev;
-
-       if (pdata) {
-               status = platform_device_add_data(pdev, pdata, pdata_len);
-               if (status < 0) {
-                       dev_dbg(&pdev->dev, "can't add platform_data\n");
-                       goto put_device;
-               }
-       }
-
-       if (irq0) {
-               struct resource r[2] = {
-                       { .start = irq0, .flags = IORESOURCE_IRQ, },
-                       { .start = irq1, .flags = IORESOURCE_IRQ, },
-               };
-
-               status = platform_device_add_resources(pdev, r, irq1 ? 2 : 1);
-               if (status < 0) {
-                       dev_dbg(&pdev->dev, "can't add irqs\n");
-                       goto put_device;
-               }
-       }
-
-       status = platform_device_add(pdev);
-       if (status)
-               goto put_device;
-
-       device_init_wakeup(&pdev->dev, can_wakeup);
-
-       return &pdev->dev;
-
-put_device:
-       platform_device_put(pdev);
-       dev_err(&twl->client->dev, "failed to add device %s\n", name);
-       return ERR_PTR(status);
-}
-
-static inline struct device *add_child(unsigned mod_no, const char *name,
-               void *pdata, unsigned pdata_len,
-               bool can_wakeup, int irq0, int irq1)
-{
-       return add_numbered_child(mod_no, name, -1, pdata, pdata_len,
-               can_wakeup, irq0, irq1);
-}
-
 /*----------------------------------------------------------------------*/
 
 /*