Staging: speakup: removing jiffies comparison using time_after_eq()
authorAshvini Varatharaj <ashvinivaratharaj@gmail.com>
Sat, 19 Oct 2013 03:21:20 +0000 (08:51 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 19 Oct 2013 12:27:15 +0000 (05:27 -0700)
Fix checkpatch warning:  Comparing jiffies is almost always wrong;
prefer time_after, time_before and friends

Signed-off-by: Ashvini Varatharaj <ashvinivaratharaj@gmail.com>
Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/speakup/speakup_acntpc.c

index 80141ac..1c8a7f4 100644 (file)
@@ -223,7 +223,7 @@ static void do_catch_up(struct spk_synth *synth)
                if (ch == '\n')
                        ch = PROCSPEECH;
                outb_p(ch, speakup_info.port_tts);
-               if (jiffies >= jiff_max && ch == SPACE) {
+               if (time_after_eq(jiffies, jiff_max) && ch == SPACE) {
                        timeout = SPK_XMITR_TIMEOUT;
                        while (synth_writable()) {
                                if (!--timeout)