misc: sprd: remove build warnings

Remove build warnings in sprd misc drivers.

Change-Id: I6d307506a956cbae56841f50a39f8fc59bc9c21e
Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>

diff --git a/drivers/misc/sprd_coda7l/vpu.c b/drivers/misc/sprd_coda7l/vpu.c
index d9163aa..a6b129f 100644 (file)
--- a/drivers/misc/sprd_coda7l/vpu.c
+++ b/drivers/misc/sprd_coda7l/vpu.c
@@ -162,9 +162,11 @@ typedef struct vpudrv_instance_pool_t {
 \r
 static int vpu_hw_reset(void);\r
 \r
+#ifdef VPU_SUPPORT_CLOCK_CONTROL\r
 static void vpu_clk_disable(struct clk *clk);\r
 static int vpu_clk_enable(struct clk *clk);\r
 static struct clk *vpu_clk_get(struct device *dev);\r
+#endif\r
 static void vpu_clk_put(struct clk *clk);\r
 \r
 \r
@@ -197,7 +199,9 @@ static struct list_head s_inst_list_head = LIST_HEAD_INIT(s_inst_list_head);
 \r
 \r
 static vpu_bit_firmware_info_t s_bit_firmware_info[MAX_NUM_VPU_CORE];\r
+#if 0\r
 static struct vpu_dev vpu_hw_dev;\r
+#endif\r
 \r
 \r
 #define BIT_BASE                    0x0000\r
@@ -224,17 +228,21 @@ static struct vpu_dev vpu_hw_dev;
 #define FORCE_SHUTDOWN                BIT_PD_CODEC_TOP_FORCE_SHUTDOWN\r
 #endif\r
 \r
+#if 0\r
 #ifdef CONFIG_PM\r
 /* implement to power management functions */\r
 static u32     s_vpu_reg_store[MAX_NUM_VPU_CORE][64];\r
 static u32 s_run_index;\r
 static u32 s_run_codstd;\r
 #endif\r
+#endif\r
 \r
 static int vpu_resume(struct platform_device *pdev);\r
 static int vpu_suspend(struct platform_device *pdev, pm_message_t state);\r
 static int vpu_set_mm_clk(void);\r
+#if 0\r
 static int vpu_set_clk_by_register(void);\r
+#endif\r
 static int vpu_clk_free(vpu_drv_context_t* vpu_context);\r
 static int vpu_power_on(void);\r
 static int vpu_power_shutdown(void);\r
@@ -283,7 +291,7 @@ static char *vpu_get_clk_src_name(unsigned int freq_level, struct clock_name_map
     return clk_map[freq_level].name;\r
 }\r
 \r
-static int find_vpu_freq_level(unsigned long freq, struct clock_name_map_t clk_map[])\r
+static int __maybe_unused find_vpu_freq_level(unsigned long freq, struct clock_name_map_t clk_map[])\r
 {\r
     int level = 0;\r
     int i;\r
@@ -298,15 +306,15 @@ static int find_vpu_freq_level(unsigned long freq, struct clock_name_map_t clk_m
 \r
 static int vpu_power_on(void)\r
 {\r
-    __raw_writel(AUTO_SHUTDOWN_EN | __raw_readl(REG_PMU_APB_CODEC_CFG), REG_PMU_APB_CODEC_CFG);\r
-    __raw_writel((~FORCE_SHUTDOWN) & __raw_readl(REG_PMU_APB_CODEC_CFG), REG_PMU_APB_CODEC_CFG);\r
+    __raw_writel(AUTO_SHUTDOWN_EN | __raw_readl((void __iomem __force *)REG_PMU_APB_CODEC_CFG), (void __iomem __force *)REG_PMU_APB_CODEC_CFG);\r
+    __raw_writel((~FORCE_SHUTDOWN) & __raw_readl((void __iomem __force *)REG_PMU_APB_CODEC_CFG), (void __iomem __force *)REG_PMU_APB_CODEC_CFG);\r
     return 0;\r
 }\r
 \r
 static int vpu_power_shutdown(void)\r
 {\r
-    __raw_writel(FORCE_SHUTDOWN | __raw_readl(REG_PMU_APB_CODEC_CFG), REG_PMU_APB_CODEC_CFG);\r
-    __raw_writel((~AUTO_SHUTDOWN_EN) & __raw_readl(REG_PMU_APB_CODEC_CFG), REG_PMU_APB_CODEC_CFG);\r
+    __raw_writel(FORCE_SHUTDOWN | __raw_readl((void __iomem __force *)REG_PMU_APB_CODEC_CFG), (void __iomem __force *)REG_PMU_APB_CODEC_CFG);\r
+    __raw_writel((~AUTO_SHUTDOWN_EN) & __raw_readl((void __iomem __force *)REG_PMU_APB_CODEC_CFG), (void __iomem __force *)REG_PMU_APB_CODEC_CFG);\r
     return 0;\r
 }\r
 \r
@@ -472,11 +480,11 @@ static int vpu_open(struct inode *inode, struct file *filp)
     ret = vpu_set_mm_clk();\r
 \r
 #if 0\r
-    vpu_logi("[VPUDRV] REG_PMU_APB_PD_MM_TOP_CFG : 0x%x\n", __raw_readl(REG_PMU_APB_PD_MM_TOP_CFG));\r
-    vpu_logi("[VPUDRV] REG_AON_APB_APB_EB0 : 0x%x\n", __raw_readl(REG_AON_APB_APB_EB0));\r
-    vpu_logi("[VPUDRV] REG_AON_APB_APB_EB1 : 0x%x\n", __raw_readl(REG_AON_APB_APB_EB1));\r
-    vpu_logi("[VPUDRV] REG_CODEC_AHB_CLOCK_SEL : 0x%x\n", __raw_readl(REG_CODEC_AHB_CLOCK_SEL));\r
-    vpu_logi("[VPUDRV] REG_CODEC_AHB_CKG_ENABLE : 0x%x\n", __raw_readl(REG_CODEC_AHB_CKG_ENABLE));\r
+    vpu_logi("[VPUDRV] REG_PMU_APB_PD_MM_TOP_CFG : 0x%x\n", __raw_readl((void __iomem __force *)REG_PMU_APB_PD_MM_TOP_CFG));\r
+    vpu_logi("[VPUDRV] REG_AON_APB_APB_EB0 : 0x%x\n", __raw_readl((void __iomem __force *)REG_AON_APB_APB_EB0));\r
+    vpu_logi("[VPUDRV] REG_AON_APB_APB_EB1 : 0x%x\n", __raw_readl((void __iomem __force *)REG_AON_APB_APB_EB1));\r
+    vpu_logi("[VPUDRV] REG_CODEC_AHB_CLOCK_SEL : 0x%x\n", __raw_readl((void __iomem __force *)REG_CODEC_AHB_CLOCK_SEL));\r
+    vpu_logi("[VPUDRV] REG_CODEC_AHB_CKG_ENABLE : 0x%x\n", __raw_readl((void __iomem __force *)REG_CODEC_AHB_CKG_ENABLE));\r
 #endif\r
 \r
 #if defined(CONFIG_SPRD_IOMMU)\r
@@ -838,8 +846,6 @@ static ssize_t vpu_write(struct file *filp, const char __user *buf, size_t len,
 \r
 static int vpu_release(struct inode *inode, struct file *filp)\r
 {\r
-    int reg_addr;\r
-\r
     spin_lock(&s_vpu_lock);\r
 \r
     vpu_logi("[VPUDRV] vpu_release, open_count= %d\n", s_vpu_drv_context.open_count);\r
@@ -1005,7 +1011,6 @@ static int vpu_probe(struct platform_device *pdev)
 {\r
     int err = 0;\r
     int ret;\r
-    int reg_addr;\r
     struct resource *res = NULL;\r
 \r
     vpu_logi("[VPUDRV] vpu_probe\n");\r
@@ -1163,9 +1168,9 @@ static int __init vpu_init(void)
 {\r
     int res = 0;\r
 \r
-    vpu_logd("vpu_init, REG_AON_APB_BOND_OPT0 = 0x%x\n", __raw_readl(REG_AON_APB_BOND_OPT0));\r
+    vpu_logd("vpu_init, REG_AON_APB_BOND_OPT0 = 0x%x\n", __raw_readl((void __iomem __force *)REG_AON_APB_BOND_OPT0));\r
 \r
-    if(__raw_readl(REG_AON_APB_BOND_OPT0) & (1<<12)) {\r
+    if(__raw_readl((void __iomem __force *)REG_AON_APB_BOND_OPT0) & (1<<12)) {\r
         return 0;\r
     }\r
 \r
@@ -1189,7 +1194,7 @@ static void __exit vpu_exit(void)
 #ifdef VPU_SUPPORT_PLATFORM_DRIVER_REGISTER\r
     vpu_logd("vpu_exit\n");\r
 \r
-    if(__raw_readl(REG_AON_APB_BOND_OPT0) & (1<<12)) {\r
+    if(__raw_readl((void __iomem __force *)REG_AON_APB_BOND_OPT0) & (1<<12)) {\r
         return ;\r
     }\r
 \r
@@ -1252,12 +1257,12 @@ int vpu_hw_reset(void)
 #if 0\r
 static int vpu_set_clk_by_register()\r
 {\r
-    __raw_writel((~(1<<25))&__raw_readl(REG_PMU_APB_PD_MM_TOP_CFG), REG_PMU_APB_PD_MM_TOP_CFG);  //0x402b_001c  (&0xfdff_ffff)\r
-    __raw_writel((0x02000000)|__raw_readl(REG_AON_APB_APB_EB0), REG_AON_APB_APB_EB0);  //0x402e_0000  (|0x0200_0000)\r
+    __raw_writel((~(1<<25))&__raw_readl((void __iomem __force *)REG_PMU_APB_PD_MM_TOP_CFG), (void __iomem __force *)REG_PMU_APB_PD_MM_TOP_CFG);  //0x402b_001c  (&0xfdff_ffff)\r
+    __raw_writel((0x02000000)|__raw_readl((void __iomem __force *)REG_AON_APB_APB_EB0), (void __iomem __force *)REG_AON_APB_APB_EB0);  //0x402e_0000  (|0x0200_0000)\r
 \r
-    __raw_writel(__raw_readl(REG_AON_APB_APB_EB1) | BIT_CODEC_EB, REG_AON_APB_APB_EB1); //0x402e_0004  (|0x0000_4000)\r
-    __raw_writel(__raw_readl(REG_CODEC_AHB_CLOCK_SEL) | 0x0333, REG_CODEC_AHB_CLOCK_SEL); //6200_0008 (|0x0333)\r
-    __raw_writel(__raw_readl(REG_CODEC_AHB_CKG_ENABLE) | 0x03, REG_CODEC_AHB_CKG_ENABLE); //6200_0004 (|0x03)\r
+    __raw_writel(__raw_readl((void __iomem __force *)REG_AON_APB_APB_EB1) | BIT_CODEC_EB, (void __iomem __force *)REG_AON_APB_APB_EB1); //0x402e_0004  (|0x0000_4000)\r
+    __raw_writel(__raw_readl((void __iomem __force *)REG_CODEC_AHB_CLOCK_SEL) | 0x0333, (void __iomem __force *)REG_CODEC_AHB_CLOCK_SEL); //6200_0008 (|0x0333)\r
+    __raw_writel(__raw_readl((void __iomem __force *)REG_CODEC_AHB_CKG_ENABLE) | 0x03, (void __iomem __force *)REG_CODEC_AHB_CKG_ENABLE); //6200_0004 (|0x03)\r
 \r
     return 0;\r
 }\r
@@ -1520,15 +1525,20 @@ errout:
     return ret;\r
 }\r
 \r
+#ifdef VPU_SUPPORT_CLOCK_CONTROL\r
 struct clk *vpu_clk_get(struct device *dev)\r
 {\r
     return clk_get(dev, VPU_CLK_NAME);\r
 }\r
+#endif\r
+\r
 void vpu_clk_put(struct clk *clk)\r
 {\r
     if (!(clk == NULL || IS_ERR(clk)))\r
         clk_put(clk);\r
 }\r
+\r
+#ifdef VPU_SUPPORT_CLOCK_CONTROL\r
 int vpu_clk_enable(struct clk *clk)\r
 {\r
 \r
@@ -1569,5 +1579,5 @@ void vpu_clk_disable(struct clk *clk)
     }\r
 #endif\r
 }\r
-\r
+#endif\r
 \r

diff --git a/drivers/misc/sprd_cproc/sprd_cproc.c b/drivers/misc/sprd_cproc/sprd_cproc.c
index 6aec251..ce0b582 100755 (executable)
--- a/drivers/misc/sprd_cproc/sprd_cproc.c
+++ b/drivers/misc/sprd_cproc/sprd_cproc.c
@@ -204,7 +204,7 @@ static ssize_t cproc_proc_read(struct file *filp,
                        vmem = ioremap_nocache(cproc->initdata->base + *ppos + CPROC_VMALLOC_SIZE_LIMIT*i, CPROC_VMALLOC_SIZE_LIMIT);
                        if (!vmem) {
                                size_t addr = cproc->initdata->base + *ppos + CPROC_VMALLOC_SIZE_LIMIT*i;
-                               printk(KERN_ERR "Unable to map cproc base: 0x%lx\n", addr);
+                               printk(KERN_ERR "Unable to map cproc base: 0x%zx\n", addr);
                                if(i > 0){
                                        *ppos += CPROC_VMALLOC_SIZE_LIMIT*i;
                                        return CPROC_VMALLOC_SIZE_LIMIT*i;
@@ -328,7 +328,7 @@ static ssize_t cproc_proc_write(struct file *filp,
                vmem = ioremap_nocache(base + offset + CPROC_VMALLOC_SIZE_LIMIT*i, CPROC_VMALLOC_SIZE_LIMIT);
                if (!vmem) {
                        size_t addr = base + offset + CPROC_VMALLOC_SIZE_LIMIT*i;
-                       printk(KERN_ERR "Unable to map cproc base: 0x%lx\n", addr);
+                       printk(KERN_ERR "Unable to map cproc base: 0x%zx\n", addr);
                        if(i > 0){
                                *ppos += CPROC_VMALLOC_SIZE_LIMIT*i;
                                return CPROC_VMALLOC_SIZE_LIMIT*i;
@@ -488,7 +488,7 @@ static int sprd_cproc_native_cp_start(void* arg)
        struct cproc_device *cproc = (struct cproc_device *)arg;
        struct cproc_init_data *pdata = cproc->initdata;
        struct cproc_ctrl *ctrl;
-       uint32_t value, state;
+       uint32_t state;
        void *vmem = NULL;
 
         if (!pdata) {
@@ -518,7 +518,7 @@ static int sprd_cproc_native_cp_start(void* arg)
                        break;
        }
 #endif
-        pr_info("deep sllep reg =0x%x, reset reg =0x%x\n", ctrl->ctrl_reg[CPROC_CTRL_DEEP_SLEEP], ctrl->ctrl_reg[CPROC_CTRL_RESET]);
+        pr_info("deep sllep reg =0x%lx, reset reg =0x%lx\n", ctrl->ctrl_reg[CPROC_CTRL_DEEP_SLEEP], ctrl->ctrl_reg[CPROC_CTRL_RESET]);
         pr_info("deep sllep mask =0x%x, reset mask =0x%x\n", ctrl->ctrl_mask[CPROC_CTRL_DEEP_SLEEP], ctrl->ctrl_mask[CPROC_CTRL_RESET]);
 
         if(ctrl->ctrl_reg[CPROC_CTRL_DEEP_SLEEP] != INVALID_REG){
@@ -689,7 +689,6 @@ static int sprd_cproc_parse_dt(struct cproc_init_data **init, struct device *dev
        struct resource res;
        struct device_node *np = dev->of_node, *chd;
        int ret, i, segnr;
-       uint32_t base, offset;
        uint32_t ctrl_reg[4] = {0};
        size_t reg_base[6] = {0};
 
@@ -721,7 +720,7 @@ static int sprd_cproc_parse_dt(struct cproc_init_data **init, struct device *dev
                goto error;
        }
        reg_base[i] = res.start;
-       pr_info("sprd_cproc: base 0x%lx\n", reg_base[i]);
+       pr_info("sprd_cproc: base 0x%x\n", reg_base[i]);
         }
        /* get ctrl_reg addr on pmu base */
        ret = of_property_read_u32_array(np, "sprd,ctrl-reg", ctrl_reg, CPROC_CTRL_NR);
@@ -729,7 +728,7 @@ static int sprd_cproc_parse_dt(struct cproc_init_data **init, struct device *dev
                goto error;
        }
        for (i = 0; i < CPROC_CTRL_NR; i++) {
-                pr_info("sprd_cproc before p2v: ctrl_reg[%d] = 0x%lx\n", i, ctrl_reg[i]);
+                pr_info("sprd_cproc before p2v: ctrl_reg[%d] = 0x%x\n", i, ctrl_reg[i]);
                 if(ctrl_reg[i] != INVALID_REG){
                     ctrl_reg[i] += reg_base[i+2];
                     ctrl->ctrl_reg[i] = SPRD_DEV_P2V(ctrl_reg[i]);
@@ -773,7 +772,7 @@ static int sprd_cproc_parse_dt(struct cproc_init_data **init, struct device *dev
                goto error;
        }
        ctrl->iram_addr = res.start;
-       pr_info("sprd_cproc: iram_addr=0x%x\n", ctrl->iram_addr);
+       pr_info("sprd_cproc: iram_addr=0x%lx\n", ctrl->iram_addr);
 
        /* get irq */
        pdata->wdtirq = irq_of_parse_and_map(np, 0);
@@ -800,7 +799,7 @@ static int sprd_cproc_parse_dt(struct cproc_init_data **init, struct device *dev
                i++;
        }
 
-       pr_info("sprd_cproc: stop callback 0x%x, start callback 0x%x\n",
+       pr_info("sprd_cproc: stop callback %p, start callback %p\n",
                sprd_cproc_native_cp_stop, sprd_cproc_native_cp_start);
        pdata->segnr = segnr;
 
@@ -865,7 +864,7 @@ static int sprd_cproc_probe(struct platform_device *pdev)
        }
 
 
-       pr_info("%s %p %x\n", __func__, pdata->base, pdata->maxsz);
+       pr_info("%s 0x%lx %x\n", __func__, pdata->base, pdata->maxsz);
 #if 0
        if ( pdata->base == WCN_START_ADDR)
                set_section_ro(__va(pdata->base), (WCN_TOTAL_SIZE & ~(SECTION_SIZE - 1)) >> SECTION_SHIFT);

diff --git a/drivers/misc/sprd_vpp/sprd_deint/vpp_deint_drv.c b/drivers/misc/sprd_vpp/sprd_deint/vpp_deint_drv.c
index 45ff3ac..1e99d9c 100755 (executable)
--- a/drivers/misc/sprd_vpp/sprd_deint/vpp_deint_drv.c
+++ b/drivers/misc/sprd_vpp/sprd_deint/vpp_deint_drv.c
@@ -125,7 +125,7 @@ static char *deint_get_clk_src_name(unsigned int freq_level)
     return clock_name_map[freq_level].name;
 }
 
-static int find_deint_freq_level(unsigned long freq)
+static int __maybe_unused find_deint_freq_level(unsigned long freq)
 {
     int level = 0;
     int i;
@@ -167,9 +167,6 @@ static void deint_free_dma_buffer(VPP_DRV_BUFFER_T *vb)
 static long deint_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
 {
     int ret;
-    struct clk *clk_parent;
-    char *name_parent;
-    unsigned long frequency;
     struct deint_fh *deint_fp = filp->private_data;
 
     if (deint_fp == NULL) {
@@ -228,7 +225,7 @@ static long deint_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
             return -EACCES;
         }
 
-        printk(KERN_ERR "SPRD_VPP_FREE_PHYSICAL_MEMORY base: 0x%x, phys_addr: 0x%x, size: 0x%x, virt_addr: 0x%x\n",
+        printk(KERN_ERR "SPRD_VPP_FREE_PHYSICAL_MEMORY base: 0x%lx, phys_addr: 0x%x, size: 0x%x, virt_addr: 0x%lx\n",
                vb.base, vb.phys_addr, vb.size, vb.virt_addr);
 
         if (vb.base)
@@ -256,7 +253,7 @@ static long deint_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
                 ret = -ETIMEDOUT;
 
                 /*clear vpp int*/
-                __raw_writel((1<<1), SPRD_VPP_BASE + VPP_INT_CLR);
+                __raw_writel((1<<1), (void __iomem __force *)(SPRD_VPP_BASE + VPP_INT_CLR));
             }
 
             put_user(ret, (int __user *)arg);
@@ -331,10 +328,10 @@ static irqreturn_t deint_isr(int irq, void *data)
         return  IRQ_NONE;
     }
 
-    ret =  __raw_readl(SPRD_VPP_BASE + VPP_INT_STS);
+    ret =  __raw_readl((void __iomem __force *)(SPRD_VPP_BASE + VPP_INT_STS));
     if((ret >> 1) & 0x1)
     {
-        __raw_writel((1<<1), SPRD_VPP_BASE + VPP_INT_CLR);
+        __raw_writel((1<<1), (void __iomem __force *)(SPRD_VPP_BASE + VPP_INT_CLR));
     }
     else
     {
@@ -607,7 +604,6 @@ static struct miscdevice deint_dev = {
 
 static int deint_suspend(struct platform_device *pdev, pm_message_t state)
 {
-    int ret=-1;
     int cnt;
     int instance_cnt = atomic_read(&deint_instance_cnt);
 
@@ -691,7 +687,6 @@ static int deint_parse_dt(struct device *dev)
 static int deint_probe(struct platform_device *pdev)
 {
     int ret;
-    struct resource *res = NULL;
 
     printk(KERN_INFO "deint_probe called !\n");
 

diff --git a/drivers/misc/sprd_vsp/sprd_vsp_sc8830.c b/drivers/misc/sprd_vsp/sprd_vsp_sc8830.c
index 6c50a2e..5d026d9 100755 (executable)
--- a/drivers/misc/sprd_vsp/sprd_vsp_sc8830.c
+++ b/drivers/misc/sprd_vsp/sprd_vsp_sc8830.c
@@ -133,7 +133,7 @@ static atomic_t vsp_instance_cnt = ATOMIC_INIT(0);
 static int total_capacity = 0;
 struct clock_name_map_t {
     unsigned long freq;
-    char *name;
+    const char *name;
 };
 
 #ifdef CONFIG_OF
@@ -170,7 +170,7 @@ static struct clock_name_map_t clock_name_map[] = {
 
 static int max_freq_level = SPRD_VSP_CLK_LEVEL_NUM;
 
-static char *vsp_get_clk_src_name(unsigned int freq_level)
+static const char *vsp_get_clk_src_name(unsigned int freq_level)
 {
     if (freq_level >= max_freq_level ) {
         printk(KERN_INFO "set freq_level to 0");
@@ -202,7 +202,7 @@ static long vsp_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
 {
     int ret;
     struct clk *clk_parent;
-    char *name_parent;
+    const char *name_parent;
     unsigned long frequency;
     struct vsp_fh *vsp_fp = filp->private_data;
 
@@ -474,7 +474,7 @@ static int vsp_parse_dt(struct device *dev)
 {
     struct device_node *np = dev->of_node;
     struct device_node *vsp_clk_np = NULL;
-    char *vsp_clk_node_name = NULL;
+    const char *vsp_clk_node_name = NULL;
     struct resource res;
     int i, ret, clk_count = 0;
 
@@ -531,13 +531,13 @@ static int vsp_parse_dt(struct device *dev)
 
     for(i = 0; i < clk_count; i++) {
         struct clk *clk_parent;
-        char *name_parent;
+        const char *name_parent;
         unsigned long frequency;
 
         name_parent = of_clk_get_parent_name(vsp_clk_np,  i);
-        clk_parent = clk_get(vsp_clk_np, name_parent);
+        clk_parent = clk_get(NULL, name_parent);
         frequency = clk_get_rate(clk_parent);
-        printk(KERN_INFO "vsp clk order in dts file: clk[%d] = (%d, %s)\n", i, frequency, name_parent);
+        printk(KERN_INFO "vsp clk order in dts file: clk[%d] = (%lu, %s)\n", i, frequency, name_parent);
 
         clock_name_map[max_freq_level-1-i].name = name_parent;
         clock_name_map[max_freq_level-1-i].freq = frequency;
@@ -576,7 +576,7 @@ static int vsp_set_mm_clk(void)
     struct clk *clk_mm_i;
     struct clk *clk_vsp;
     struct clk *clk_parent;
-    char *name_parent;
+    const char *name_parent;
     int instance_cnt = atomic_read(&vsp_instance_cnt);
 
     printk(KERN_INFO "vsp_set_mm_clk: vsp_instance_cnt %d\n", instance_cnt);
@@ -735,7 +735,6 @@ static int vsp_open(struct inode *inode, struct file *filp)
 
 static int vsp_release (struct inode *inode, struct file *filp)
 {
-    int ret;
     struct vsp_fh *vsp_fp = filp->private_data;
     int instance_cnt = atomic_read(&vsp_instance_cnt);
 
@@ -801,7 +800,6 @@ static struct miscdevice vsp_dev = {
 
 static int vsp_suspend(struct platform_device *pdev, pm_message_t state)
 {
-    int ret=-1;
     int cnt;
     int instance_cnt = atomic_read(&vsp_instance_cnt);