pwm: sun4i: Don't check the return code of pwmchip_remove()
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Wed, 7 Jul 2021 16:28:34 +0000 (18:28 +0200)
committerThierry Reding <thierry.reding@gmail.com>
Thu, 2 Sep 2021 19:38:55 +0000 (21:38 +0200)
pwmchip_remove() returns always 0. Don't use the value to make it
possible to eventually change the function to return void. Also the
driver core ignores the return value of sun4i_pwm_remove()
and considers the device removed anyhow. So returning early results
in a resource leak.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
drivers/pwm/pwm-sun4i.c

index c952604e91f3a3065c4e702566679a11d2f6d41c..91ca67651abd5ebb7b92e3bd0b3b5ad398fd0321 100644 (file)
@@ -484,11 +484,8 @@ err_bus:
 static int sun4i_pwm_remove(struct platform_device *pdev)
 {
        struct sun4i_pwm_chip *pwm = platform_get_drvdata(pdev);
-       int ret;
 
-       ret = pwmchip_remove(&pwm->chip);
-       if (ret)
-               return ret;
+       pwmchip_remove(&pwm->chip);
 
        clk_disable_unprepare(pwm->bus_clk);
        reset_control_assert(pwm->rst);