[lldbsuite] Un-xfail tests on Windows that are now passing
authorStella Stamenova <stilis@microsoft.com>
Wed, 19 Dec 2018 19:04:01 +0000 (19:04 +0000)
committerStella Stamenova <stilis@microsoft.com>
Wed, 19 Dec 2018 19:04:01 +0000 (19:04 +0000)
This is a set of tests that were all marked as failing becuse of pr24489. The bug is not fixed (as in more of the tests that were marked this way are failing), but this set is passing. It is possible that some of them are false positives, but there's a large number of unexpectedly passing tests on Windows, so I am doing a bulk un-xfail to get the buildbot to green.

llvm-svn: 349665

lldb/packages/Python/lldbsuite/test/expression_command/anonymous-struct/TestCallUserAnonTypedef.py
lldb/packages/Python/lldbsuite/test/expression_command/call-function/TestCallStopAndContinue.py
lldb/packages/Python/lldbsuite/test/expression_command/call-function/TestCallUserDefinedFunction.py
lldb/packages/Python/lldbsuite/test/expression_command/completion/TestExprCompletion.py
lldb/packages/Python/lldbsuite/test/expression_command/test/TestExprs2.py
lldb/packages/Python/lldbsuite/test/lang/cpp/call-function/TestCallCPPFunction.py
lldb/packages/Python/lldbsuite/test/lang/cpp/overloaded-functions/TestOverloadedFunctions.py
lldb/packages/Python/lldbsuite/test/lang/cpp/rvalue-references/TestRvalueReferences.py
lldb/packages/Python/lldbsuite/test/lang/cpp/template/TestTemplateArgs.py
lldb/packages/Python/lldbsuite/test/lang/cpp/unicode-literals/TestUnicodeLiterals.py

index 6a8fb5d..1108b12 100644 (file)
@@ -23,7 +23,6 @@ class TestExprLookupAnonStructTypedef(TestBase):
         # Find the breakpoint
         self.line = line_number('main.cpp', '// lldb testsuite break')
 
-    @expectedFailureAll(oslist=["windows"])
     @expectedFailureAll(
         oslist=['linux'],
         archs=['arm'],
index 6351177..8709955 100644 (file)
@@ -25,9 +25,6 @@ class ExprCommandCallStopContinueTestCase(TestBase):
         self.func_line = line_number('main.cpp', '{5, "five"}')
 
     @expectedFlakeyDarwin("llvm.org/pr20274")
-    @expectedFailureAll(
-        oslist=["windows"],
-        bugnumber="llvm.org/pr24489: Name lookup not working correctly on Windows")
     def test(self):
         """Test gathering result from interrupted function call."""
         self.build()
index 3ea7d9b..0eb7086 100644 (file)
@@ -28,9 +28,6 @@ class ExprCommandCallUserDefinedFunction(TestBase):
             'main.cpp',
             '// Please test these expressions while stopped at this line:')
 
-    @expectedFailureAll(
-        oslist=["windows"],
-        bugnumber="llvm.org/pr24489: Name lookup not working correctly on Windows")
     def test(self):
         """Test return values of user defined function calls."""
         self.build()
index c33120c..536b9e0 100644 (file)
@@ -18,7 +18,6 @@ class CommandLineExprCompletionTestCase(TestBase):
 
     NO_DEBUG_INFO_TESTCASE = True
 
-    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24489")
     def test_expr_completion(self):
         self.build()
         self.main_source = "main.cpp"
@@ -195,7 +194,6 @@ class CommandLineExprCompletionTestCase(TestBase):
         self.complete_exactly('expr some_expr.Self(). FooNoArgs',
                               'expr some_expr.Self(). FooNoArgsBar()')
 
-    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24489")
     def test_expr_completion_with_descriptions(self):
         self.build()
         self.main_source = "main.cpp"
@@ -227,7 +225,6 @@ class CommandLineExprCompletionTestCase(TestBase):
             ["some_expr.MemberVariableBar", "int"],
         ])
 
-
     def assume_no_completions(self, str_input, cursor_pos = None):
         interp = self.dbg.GetCommandInterpreter()
         match_strings = lldb.SBStringList()
index f5ec4f0..88412e6 100644 (file)
@@ -24,9 +24,6 @@ class ExprCommands2TestCase(TestBase):
             'main.cpp',
             '// Please test many expressions while stopped at this line:')
 
-    @expectedFailureAll(
-        oslist=["windows"],
-        bugnumber="llvm.org/pr24489: Name lookup not working correctly on Windows")
     def test_more_expr_commands(self):
         """Test some more expression commands."""
         self.build()
@@ -60,9 +57,7 @@ class ExprCommands2TestCase(TestBase):
         # (int) $5 = 6
 
     @skipIfLinux
-    @expectedFailureAll(
-            oslist=["windows"],
-            bugnumber="llvm.org/pr24489: Name lookup not working correctly on Windows")
+    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24489")
     def test_expr_symbols(self):
         """Test symbols."""
         self.build()
index 9b227bc..b6274b3 100644 (file)
@@ -16,9 +16,6 @@ class CallCPPFunctionTestCase(TestBase):
         TestBase.setUp(self)
         self.line = line_number('main.cpp', '// breakpoint')
 
-    @expectedFailureAll(
-        oslist=["windows"],
-        bugnumber="llvm.org/pr24489: Name lookup not working correctly on Windows")
     def test_with_run_command(self):
         """Test calling a function by basename"""
         self.build()
index 7f68eb8..ad969ef 100644 (file)
@@ -16,9 +16,6 @@ class OverloadedFunctionsTestCase(TestBase):
         TestBase.setUp(self)
         self.line = line_number('main.cpp', '// breakpoint')
 
-    @expectedFailureAll(
-        oslist=["windows"],
-        bugnumber="llvm.org/pr24489: Name lookup not working correctly on Windows")
     def test_with_run_command(self):
         """Test that functions with the same name are resolved correctly"""
         self.build()
index cc79366..5e31d93 100644 (file)
@@ -16,9 +16,6 @@ class RvalueReferencesTestCase(TestBase):
     @expectedFailureAll(
         compiler="icc",
         bugnumber="ICC (13.1, 14-beta) do not emit DW_TAG_rvalue_reference_type.")
-    @expectedFailureAll(
-        oslist=["windows"],
-        bugnumber="llvm.org/pr24489: Name lookup not working correctly on Windows")
     def test_with_run_command(self):
         """Test that rvalues are supported in the C++ expression parser"""
         self.build()
index 054bc93..8f2ab56 100644 (file)
@@ -47,7 +47,6 @@ class TemplateArgsTestCase(TestBase):
         # Get frame for current thread
         return thread.GetSelectedFrame()
 
-    @expectedFailureAll(oslist=["windows"])
     def test_integer_args(self):
         frame = self.prepareProcess()
 
@@ -111,11 +110,9 @@ class TemplateArgsTestCase(TestBase):
         self.assertTrue(f4.GetType().GetName() == 'int')
         self.assertTrue(f4.GetValue() == '42')
 
-
     # Gcc does not generate the necessary DWARF attribute for enum template
     # parameters.
     @expectedFailureAll(bugnumber="llvm.org/pr28354", compiler="gcc")
-    @expectedFailureAll(oslist=["windows"])
     def test_enum_args(self):
         frame = self.prepareProcess()
 
index 216f860..1a50c9d 100644 (file)
@@ -31,25 +31,16 @@ class UnicodeLiteralsTestCase(TestBase):
 
     mydir = TestBase.compute_mydir(__file__)
 
-    @expectedFailureAll(
-        oslist=["windows"],
-        bugnumber="llvm.org/pr24489: Name lookup not working correctly on Windows")
     def test_expr1(self):
         """Test that the expression parser returns proper Unicode strings."""
         self.build()
         self.rdar12991846(expr=1)
 
-    @expectedFailureAll(
-        oslist=["windows"],
-        bugnumber="llvm.org/pr24489: Name lookup not working correctly on Windows")
     def test_expr2(self):
         """Test that the expression parser returns proper Unicode strings."""
         self.build()
         self.rdar12991846(expr=2)
 
-    @expectedFailureAll(
-        oslist=["windows"],
-        bugnumber="llvm.org/pr24489: Name lookup not working correctly on Windows")
     def test_expr3(self):
         """Test that the expression parser returns proper Unicode strings."""
         self.build()