drm/vc4: Limit max_bpc to 8 on Pi0-3
authorDave Stevenson <dave.stevenson@raspberrypi.com>
Mon, 24 Apr 2023 17:32:45 +0000 (18:32 +0100)
committerDom Cobley <popcornmix@gmail.com>
Mon, 19 Feb 2024 11:31:27 +0000 (11:31 +0000)
Pi 0-3 have no deep colour support and only 24bpp output,
so max_bpc should remain as 8.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
drivers/gpu/drm/vc4/vc4_hdmi.c

index 97e40e3..b2c1e63 100644 (file)
@@ -756,7 +756,6 @@ static int vc4_hdmi_connector_init(struct drm_device *dev,
 
        drm_connector_attach_colorspace_property(connector);
        drm_connector_attach_tv_margin_properties(connector);
-       drm_connector_attach_max_bpc_property(connector, 8, 12);
 
        connector->polled = (DRM_CONNECTOR_POLL_CONNECT |
                             DRM_CONNECTOR_POLL_DISCONNECT);
@@ -765,8 +764,12 @@ static int vc4_hdmi_connector_init(struct drm_device *dev,
        connector->doublescan_allowed = 0;
        connector->stereo_allowed = 1;
 
-       if (vc4_hdmi->variant->supports_hdr)
+       if (vc4_hdmi->variant->supports_hdr) {
+               drm_connector_attach_max_bpc_property(connector, 8, 12);
                drm_connector_attach_hdr_output_metadata_property(connector);
+       } else {
+               drm_connector_attach_max_bpc_property(connector, 8, 8);
+       }
 
        vc4_hdmi_attach_broadcast_rgb_property(dev, vc4_hdmi);