pwm: ab8500: Fix error code in probe()
authorDan Carpenter <dan.carpenter@linaro.org>
Mon, 22 May 2023 11:07:42 +0000 (14:07 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 19 Jul 2023 14:21:59 +0000 (16:21 +0200)
[ Upstream commit cdcffafc4d845cc0c6392cba168c7a942734cce7 ]

This code accidentally return positive EINVAL instead of negative
-EINVAL.

Fixes: eb41f334589d ("pwm: ab8500: Fix register offset calculation to not depend on probe order")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/pwm/pwm-ab8500.c

index ad37bc4..5fa91f4 100644 (file)
@@ -96,7 +96,7 @@ static int ab8500_pwm_probe(struct platform_device *pdev)
        int err;
 
        if (pdev->id < 1 || pdev->id > 31)
-               return dev_err_probe(&pdev->dev, EINVAL, "Invalid device id %d\n", pdev->id);
+               return dev_err_probe(&pdev->dev, -EINVAL, "Invalid device id %d\n", pdev->id);
 
        /*
         * Nothing to be done in probe, this is required to get the