test: add test-npm-install to parallel tests suite
authorMyles Borins <mborins@us.ibm.com>
Tue, 9 Feb 2016 18:32:32 +0000 (10:32 -0800)
committerMyles Borins <mborins@us.ibm.com>
Wed, 30 Mar 2016 20:12:14 +0000 (13:12 -0700)
Currently we are not testing that `npm install` works.

This is a very naive / basic test that shells out to `npm install`
in an empty `tempDir`. While this test will not be able to check
that `npm install` is 100% working, it should catch certain edge
cases that break it.

PR-URL: https://github.com/nodejs/node/pull/5166
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Alexis Campailla <orangemocha@nodejs.org>
test/parallel/test-npm-install.js [new file with mode: 0644]

diff --git a/test/parallel/test-npm-install.js b/test/parallel/test-npm-install.js
new file mode 100644 (file)
index 0000000..5275b17
--- /dev/null
@@ -0,0 +1,40 @@
+'use strict';
+const common = require('../common');
+
+const path = require('path');
+const spawn = require('child_process').spawn;
+const assert = require('assert');
+const fs = require('fs');
+
+common.refreshTmpDir();
+
+const npmPath = path.join(
+  common.testDir,
+  '..',
+  'deps',
+  'npm',
+  'bin',
+  'npm-cli.js'
+);
+
+const args = [
+  npmPath,
+  'install'
+];
+
+const pkgContent = '{}';
+
+const pkgPath = path.join(common.tmpDir, 'package.json');
+
+fs.writeFileSync(pkgPath, pkgContent);
+
+const proc = spawn(process.execPath, args, {
+  cwd: common.tmpDir
+});
+
+function handleExit(code, signalCode) {
+  assert.equal(code, 0, 'npm install should run without an error');
+  assert.ok(signalCode === null, 'signalCode should be null');
+}
+
+proc.on('exit', common.mustCall(handleExit));