cmd: dfu: Propagate error if dfu gadget fails
authorMichal Simek <michal.simek@xilinx.com>
Wed, 31 Mar 2021 07:05:52 +0000 (09:05 +0200)
committerMichal Simek <michal.simek@xilinx.com>
Fri, 23 Apr 2021 06:45:55 +0000 (08:45 +0200)
On systems without usb gadget dfu core fails which was reported by error
but command itself returns pass which breaks any usage in a script.
That's why propagate error from run_usb_dnl_gadget().

Fixes: 16297cfb2a20 ("usb: new board-specific USB init interface")
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
cmd/dfu.c

index ef4f897..4a288f7 100644 (file)
--- a/cmd/dfu.c
+++ b/cmd/dfu.c
@@ -68,7 +68,7 @@ static int do_dfu(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])
        int controller_index = simple_strtoul(usb_controller, NULL, 0);
        bool retry = false;
        do {
-               run_usb_dnl_gadget(controller_index, "usb_dnl_dfu");
+               ret = run_usb_dnl_gadget(controller_index, "usb_dnl_dfu");
 
                if (dfu_reinit_needed) {
                        dfu_free_entities();