telepathy: Fix notification of is-favourite changes

This ensures that the UI reflects errors in changing the is-favourite status
of a Tpf.Persona, rather than just blindly assuming they succeed.

diff --git a/backends/telepathy/lib/tpf-persona.vala b/backends/telepathy/lib/tpf-persona.vala
index eae6551..b8543af 100644 (file)
--- a/backends/telepathy/lib/tpf-persona.vala
+++ b/backends/telepathy/lib/tpf-persona.vala
@@ -338,12 +338,17 @@ public class Tpf.Persona : Folks.Persona,
               is_favourite);
         }
 
-      this._is_favourite = is_favourite;
-      this.notify_property ("is-favourite");
+      /* The change will be notified when we receive changes from the store. */
     }
 
+  /* Note: Only ever called by Tpf.PersonaStore. */
   internal void _set_is_favourite (bool is_favourite)
     {
+      if (this._is_favourite == is_favourite)
+        {
+          return;
+        }
+
       this._is_favourite = is_favourite;
       this.notify_property ("is-favourite");
     }