ore: signedness bug in _sp2d_min_pg()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 2 Oct 2012 08:28:45 +0000 (11:28 +0300)
committerBoaz Harrosh <bharrosh@panasas.com>
Wed, 3 Oct 2012 20:51:51 +0000 (13:51 -0700)
This for loop doesn't work correctly when "p" is unsigned.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
fs/exofs/ore_raid.c

index 5f376d1..b963f38 100644 (file)
@@ -203,7 +203,7 @@ static unsigned _sp2d_min_pg(struct __stripe_pages_2d *sp2d)
 
 static unsigned _sp2d_max_pg(struct __stripe_pages_2d *sp2d)
 {
-       unsigned p;
+       int p;
 
        for (p = sp2d->pages_in_unit - 1; p >= 0; --p) {
                struct __1_page_stripe *_1ps = &sp2d->_1p_stripes[p];