tcp: cleanup static functions
authorEric Dumazet <edumazet@google.com>
Fri, 27 Feb 2015 03:08:59 +0000 (19:08 -0800)
committerDavid S. Miller <davem@davemloft.net>
Sat, 28 Feb 2015 21:56:51 +0000 (16:56 -0500)
tcp_fastopen_create_child() is static and should not be exported.

tcp4_gso_segment() and tcp6_gso_segment() should be static.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/tcp_fastopen.c
net/ipv4/tcp_offload.c
net/ipv6/tcpv6_offload.c

index ea82fd4..fe77417 100644 (file)
@@ -221,7 +221,6 @@ static bool tcp_fastopen_create_child(struct sock *sk,
        WARN_ON(req->sk == NULL);
        return true;
 }
-EXPORT_SYMBOL(tcp_fastopen_create_child);
 
 static bool tcp_fastopen_queue_check(struct sock *sk)
 {
index 9d7930b..3f7c2fc 100644 (file)
@@ -29,8 +29,8 @@ static void tcp_gso_tstamp(struct sk_buff *skb, unsigned int ts_seq,
        }
 }
 
-struct sk_buff *tcp4_gso_segment(struct sk_buff *skb,
-                                netdev_features_t features)
+static struct sk_buff *tcp4_gso_segment(struct sk_buff *skb,
+                                       netdev_features_t features)
 {
        if (!pskb_may_pull(skb, sizeof(struct tcphdr)))
                return ERR_PTR(-EINVAL);
index c1ab771..d883c92 100644 (file)
@@ -41,8 +41,8 @@ static int tcp6_gro_complete(struct sk_buff *skb, int thoff)
        return tcp_gro_complete(skb);
 }
 
-struct sk_buff *tcp6_gso_segment(struct sk_buff *skb,
-                                netdev_features_t features)
+static struct sk_buff *tcp6_gso_segment(struct sk_buff *skb,
+                                       netdev_features_t features)
 {
        struct tcphdr *th;