drm/amd/display: AUX tracing cleanup
authorLeo (Hanghong) Ma <hanghong.ma@amd.com>
Tue, 20 Sep 2022 19:23:42 +0000 (15:23 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 6 Oct 2022 15:59:48 +0000 (11:59 -0400)
[Why && How]
Remove the unnecessary AUX trace and use one trace for AUX failure.

Reviewed-by: Martin Leung <Martin.Leung@amd.com>
Acked-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
Signed-off-by: Leo (Hanghong) Ma <hanghong.ma@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/dce/dce_aux.c

index 32782ef..140297c 100644 (file)
@@ -942,10 +942,6 @@ bool dce_aux_transfer_with_retries(struct ddc_service *ddc,
                case AUX_RET_ERROR_ENGINE_ACQUIRE:
                case AUX_RET_ERROR_UNKNOWN:
                default:
-                       DC_TRACE_LEVEL_MESSAGE(DAL_TRACE_LEVEL_INFORMATION,
-                                               LOG_FLAG_I2cAux_DceAux,
-                                               "dce_aux_transfer_with_retries: Failure: operation_result=%d",
-                                               (int)operation_result);
                        goto fail;
                }
        }
@@ -953,14 +949,11 @@ bool dce_aux_transfer_with_retries(struct ddc_service *ddc,
 fail:
        DC_TRACE_LEVEL_MESSAGE(DAL_TRACE_LEVEL_ERROR,
                                LOG_FLAG_Error_I2cAux,
-                               "dce_aux_transfer_with_retries: FAILURE");
+                               "%s: Failure: operation_result=%d",
+                               __func__,
+                               (int)operation_result);
        if (!payload_reply)
                payload->reply = NULL;
 
-       DC_TRACE_LEVEL_MESSAGE(DAL_TRACE_LEVEL_ERROR,
-                               WPP_BIT_FLAG_DC_ERROR,
-                               "AUX transaction failed. Result: %d",
-                               operation_result);
-
        return false;
 }