[clang][ExtractAPI] Fix -Wpessimizing-move in DeclarationFragments.h (NFC)

/Users/jiefu/llvm-project/clang/include/clang/ExtractAPI/DeclarationFragments.h:118:26: error: moving a temporary object prevents copy elision [-Werror,-Wpessimizing-move]
    Fragments.insert(It, std::move(Fragment(Spelling, Kind, PreciseIdentifier,
                         ^
/Users/jiefu/llvm-project/clang/include/clang/ExtractAPI/DeclarationFragments.h:118:26: note: remove std::move call here
    Fragments.insert(It, std::move(Fragment(Spelling, Kind, PreciseIdentifier,
                         ^~~~~~~~~~
1 error generated.

diff --git a/clang/include/clang/ExtractAPI/DeclarationFragments.h b/clang/include/clang/ExtractAPI/DeclarationFragments.h
index 4c1b830..3b909b0 100644 (file)
--- a/clang/include/clang/ExtractAPI/DeclarationFragments.h
+++ b/clang/include/clang/ExtractAPI/DeclarationFragments.h
@@ -115,8 +115,8 @@ public:
                                FragmentKind Kind,
                                StringRef PreciseIdentifier = "",
                                const Decl *Declaration = nullptr) {
-    Fragments.insert(It, std::move(Fragment(Spelling, Kind, PreciseIdentifier,
-                                            Declaration)));
+    Fragments.insert(It, Fragment(Spelling, Kind, PreciseIdentifier,
+                                            Declaration));
     return *this;
   }