Replace for_each_*_bit_from() with for_each_*_bit() where appropriate
authorYury Norov <yury.norov@gmail.com>
Sat, 14 Aug 2021 21:17:08 +0000 (14:17 -0700)
committerYury Norov <yury.norov@gmail.com>
Sat, 15 Jan 2022 16:47:31 +0000 (08:47 -0800)
A couple of kernel functions call for_each_*_bit_from() with start
bit equal to 0. Replace them with for_each_*_bit().

No functional changes, but might improve on readability.

Signed-off-by: Yury Norov <yury.norov@gmail.com>
Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
arch/x86/kernel/apic/vector.c
drivers/gpu/drm/etnaviv/etnaviv_gpu.c
drivers/hwmon/ltc2992.c

index c132daabe6152282b042ece88fd6a586c1f45085..3e6f6b448f6aaa4eb19b1976162f05cd30b094cf 100644 (file)
@@ -760,9 +760,9 @@ void __init lapic_update_legacy_vectors(void)
 
 void __init lapic_assign_system_vectors(void)
 {
-       unsigned int i, vector = 0;
+       unsigned int i, vector;
 
-       for_each_set_bit_from(vector, system_vectors, NR_VECTORS)
+       for_each_set_bit(vector, system_vectors, NR_VECTORS)
                irq_matrix_assign_system(vector_matrix, vector, false);
 
        if (nr_legacy_irqs() > 1)
index 242a5fd8b93212d9481d5aec67e569d01d728d47..06bde46df451a5d1b7f82bb9c5a5d65f108ce486 100644 (file)
@@ -1047,7 +1047,7 @@ pm_put:
 
 void etnaviv_gpu_recover_hang(struct etnaviv_gpu *gpu)
 {
-       unsigned int i = 0;
+       unsigned int i;
 
        dev_err(gpu->dev, "recover hung GPU!\n");
 
@@ -1060,7 +1060,7 @@ void etnaviv_gpu_recover_hang(struct etnaviv_gpu *gpu)
 
        /* complete all events, the GPU won't do it after the reset */
        spin_lock(&gpu->event_spinlock);
-       for_each_set_bit_from(i, gpu->event_bitmap, ETNA_NR_EVENTS)
+       for_each_set_bit(i, gpu->event_bitmap, ETNA_NR_EVENTS)
                complete(&gpu->event_free);
        bitmap_zero(gpu->event_bitmap, ETNA_NR_EVENTS);
        spin_unlock(&gpu->event_spinlock);
index 2a4bed0ab226bdfd76d80b8ebe1a43bfb8a5e71d..7352d2b3c756d7c9820f972ac5444430c6824af7 100644 (file)
@@ -248,8 +248,7 @@ static int ltc2992_gpio_get_multiple(struct gpio_chip *chip, unsigned long *mask
 
        gpio_status = reg;
 
-       gpio_nr = 0;
-       for_each_set_bit_from(gpio_nr, mask, LTC2992_GPIO_NR) {
+       for_each_set_bit(gpio_nr, mask, LTC2992_GPIO_NR) {
                if (test_bit(LTC2992_GPIO_BIT(gpio_nr), &gpio_status))
                        set_bit(gpio_nr, bits);
        }