hdt: Fixing argument mgmt in cli
authorErwan Velu <erwanaliasr1@gmail.com>
Sun, 27 May 2012 09:20:01 +0000 (11:20 +0200)
committerErwan Velu <erwanaliasr1@gmail.com>
Sun, 27 May 2012 09:20:01 +0000 (11:20 +0200)
Sizeof(char *) is definetly wrong for getting the length of a string.

com32/hdt/hdt-cli.c

index 85bd13f..3dd982e 100644 (file)
@@ -391,8 +391,8 @@ static void parse_command_line(char *line, char **command, char **module,
     pch = strtok(line + args_pos, CLI_SPACE);
     while (pch != NULL) {
        dprintf("CLI DEBUG parse: argv[%d] = %s\n", argc_iter, pch);
-       argv[argc_iter] = malloc(sizeof(pch) * sizeof(char));
-       strlcpy(argv[argc_iter], pch, sizeof(pch));
+       argv[argc_iter] = malloc(strlen(pch) * sizeof(char));
+       strlcpy(argv[argc_iter], pch, strlen(pch));
        argc_iter++;
        pch = strtok(NULL, CLI_SPACE);
        /*