media: ccs: avoid printing an uninitialized variable
authorArnd Bergmann <arnd@arndb.de>
Thu, 3 Dec 2020 22:28:16 +0000 (23:28 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Mon, 7 Dec 2020 12:55:40 +0000 (13:55 +0100)
There is no intialization for the 'reg' variable, so printing
it produces undefined behavior as well as a compile-time warning:

drivers/media/i2c/ccs/ccs-core.c:314:49: error: variable 'reg' is uninitialized when used here [-Werror,-Wuninitialized]
                        "0x%8.8x %s pixels: %d %s (pixelcode %u)\n", reg,

Remove the variable and stop printing it.

Fixes: fd9065812c7b ("media: smiapp: Obtain frame descriptor from CCS limits")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/i2c/ccs/ccs-core.c

index 4447ca3..7a461c0 100644 (file)
@@ -268,7 +268,6 @@ static int ccs_read_frame_fmt(struct ccs_sensor *sensor)
                u32 pixels;
                char *which;
                char *what;
-               u32 reg;
 
                if (fmt_model_type == CCS_FRAME_FORMAT_MODEL_TYPE_2_BYTE) {
                        desc = CCS_LIM_AT(sensor, FRAME_FORMAT_DESCRIPTOR, i);
@@ -322,7 +321,7 @@ static int ccs_read_frame_fmt(struct ccs_sensor *sensor)
                }
 
                dev_dbg(&client->dev,
-                       "0x%8.8x %s pixels: %d %s (pixelcode %u)\n", reg,
+                       "%s pixels: %d %s (pixelcode %u)\n",
                        what, pixels, which, pixelcode);
 
                if (i < ncol_desc) {