-Wpointer-sign: xcoffread.c.

../../src/gdb/xcoffread.c: In function ‘xcoff_initial_scan’:
../../src/gdb/xcoffread.c:2982:17: error: pointer targets in assignment differ in signedness [-Werror=pointer-sign]

'debugsec' is a 'bfd_byte *', holding the result of a
bfd_get_full_section_contents.  'info->debugsec' holds the same
contents throughout the whole xcoff read, and everywhere it's used to
read symbol names.  Simply adding a cast feels appropriate.

gdb/
2013-04-19  Pedro Alves  <palves@redhat.com>

	* xcoffread.c (xcoff_initial_scan): Add cast to 'char *'.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 47a8ac2..a28fdad 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,9 @@
 2013-04-19  Pedro Alves  <palves@redhat.com>
 
+       * xcoffread.c (xcoff_initial_scan): Add cast to 'char *'.
+
+2013-04-19  Pedro Alves  <palves@redhat.com>
+
        * coff-pe-read.c (read_pe_exported_syms): Handle strings as char.
 
 2013-04-19  Pedro Alves  <palves@redhat.com>

diff --git a/gdb/xcoffread.c b/gdb/xcoffread.c
index 6013551..2b5f9b7 100644 (file)
--- a/gdb/xcoffread.c
+++ b/gdb/xcoffread.c
@@ -2979,7 +2979,7 @@ xcoff_initial_scan (struct objfile *objfile, int symfile_flags)
                  }
              }
          }
-       info->debugsec = debugsec;
+       info->debugsec = (char *) debugsec;
       }
     }