i40e: Do not check VF state in i40e_ndo_get_vf_config
authorLihong Yang <lihong.yang@intel.com>
Wed, 5 Jun 2019 19:45:15 +0000 (12:45 -0700)
committerDavid S. Miller <davem@davemloft.net>
Wed, 5 Jun 2019 23:53:25 +0000 (16:53 -0700)
The VF configuration returned in i40e_ndo_get_vf_config is
already stored by the PF. There is no dependency on any
specific state of the VF to return the configuration.
Drop the check against I40E_VF_STATE_INIT since it is not
needed.

Signed-off-by: Lihong Yang <lihong.yang@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c

index 479bc60..f143678 100644 (file)
@@ -4302,10 +4302,8 @@ int i40e_ndo_get_vf_config(struct net_device *netdev,
        vf = &pf->vf[vf_id];
        /* first vsi is always the LAN vsi */
        vsi = pf->vsi[vf->lan_vsi_idx];
-       if (!test_bit(I40E_VF_STATE_INIT, &vf->vf_states)) {
-               dev_err(&pf->pdev->dev, "VF %d still in reset. Try again.\n",
-                       vf_id);
-               ret = -EAGAIN;
+       if (!vsi) {
+               ret = -ENOENT;
                goto error_param;
        }