pinctrl: mlxbf3: set varaiable mlxbf3_pmx_funcs storage-class-specifier to static
authorTom Rix <trix@redhat.com>
Tue, 4 Apr 2023 00:45:01 +0000 (20:45 -0400)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 4 Apr 2023 14:07:06 +0000 (16:07 +0200)
smatch reports
drivers/pinctrl/pinctrl-mlxbf3.c:162:20: warning: symbol
  'mlxbf3_pmx_funcs' was not declared. Should it be static?

This variable is only used in one file so it should be static.

Signed-off-by: Tom Rix <trix@redhat.com>
Link: https://lore.kernel.org/r/20230404004501.1913144-1-trix@redhat.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-mlxbf3.c

index 3698f7b..d9944e6 100644 (file)
@@ -159,7 +159,7 @@ static const struct pinctrl_ops mlxbf3_pinctrl_group_ops = {
 static const char * const mlxbf3_gpiofunc_group_names[] = { "swctrl" };
 static const char * const mlxbf3_hwfunc_group_names[]   = { "hwctrl" };
 
-struct pinfunction mlxbf3_pmx_funcs[] = {
+static struct pinfunction mlxbf3_pmx_funcs[] = {
        PINCTRL_PINFUNCTION("hwfunc", mlxbf3_hwfunc_group_names, 1),
        PINCTRL_PINFUNCTION("gpiofunc", mlxbf3_gpiofunc_group_names, 1),
 };