vfio: use the new pci_dev_trylock() helper to simplify try lock
authorLuis Chamberlain <mcgrof@kernel.org>
Wed, 23 Jun 2021 02:28:24 +0000 (19:28 -0700)
committerAlex Williamson <alex.williamson@redhat.com>
Thu, 24 Jun 2021 19:32:31 +0000 (13:32 -0600)
Use the new pci_dev_trylock() helper to simplify our locking.

Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Link: https://lore.kernel.org/r/20210623022824.308041-3-mcgrof@kernel.org
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
drivers/vfio/pci/vfio_pci.c

index f6729ba..759dfb1 100644 (file)
@@ -477,13 +477,10 @@ static void vfio_pci_disable(struct vfio_pci_device *vdev)
         * We can not use the "try" reset interface here, which will
         * overwrite the previously restored configuration information.
         */
-       if (vdev->reset_works && pci_cfg_access_trylock(pdev)) {
-               if (device_trylock(&pdev->dev)) {
-                       if (!__pci_reset_function_locked(pdev))
-                               vdev->needs_reset = false;
-                       device_unlock(&pdev->dev);
-               }
-               pci_cfg_access_unlock(pdev);
+       if (vdev->reset_works && pci_dev_trylock(pdev)) {
+               if (!__pci_reset_function_locked(pdev))
+                       vdev->needs_reset = false;
+               pci_dev_unlock(pdev);
        }
 
        pci_restore_state(pdev);