drivers/block/swim3.c: fix null pointer dereference
authorCong Ding <dinggnu@gmail.com>
Thu, 21 Feb 2013 23:16:40 +0000 (15:16 -0800)
committerJens Axboe <axboe@kernel.dk>
Fri, 22 Feb 2013 09:42:46 +0000 (10:42 +0100)
The use of pointer fs should be after the null check.

Signed-off-by: Cong Ding <dinggnu@gmail.com>
Cc: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/swim3.c

index 57763c5..758f2ac 100644 (file)
@@ -1090,10 +1090,13 @@ static const struct block_device_operations floppy_fops = {
 static void swim3_mb_event(struct macio_dev* mdev, int mb_state)
 {
        struct floppy_state *fs = macio_get_drvdata(mdev);
-       struct swim3 __iomem *sw = fs->swim3;
+       struct swim3 __iomem *sw;
 
        if (!fs)
                return;
+
+       sw = fs->swim3;
+
        if (mb_state != MB_FD)
                return;