elm naviframe: Fixed omitting signal emission when customized text parts change the...

On Sun, Jan 6, 2013 at 2:23 PM, 조재현 <jae_hyun_cho@naver.com> wrote:
Dear all,

Hello. This is Jaehyun Cho.
Now, naviframe emits state signals (e.g. show or hide) for customized text part (i.e. neither "elm.text.title" nor "elm.text.subtitle") which is going to be appended to the item's text_list.
However, if the customized text parts change the text label when the text parts are in the item's text_list, naviframe does not emit state signals for them.
To resolve this issue, I added additional case in _item_text_set_hook to handle the text part which is in the item's text_list. (elementary/src/lib/elc_naviframe.c)
Please review this.

Thank you,
Jaehyun Cho.

SVN revision: 82300

diff --git a/ChangeLog b/ChangeLog
index 7f4f1fa..d65319c 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -890,3 +890,7 @@
 2012-01-05  ChunEon Park <hermet@hermet.pe.kr>
 
         * Added a label signal callback "slide,end"
+
+2013-01-06  Jaehyun Cho <jae_hyun_cho@naver.com>
+
+        * Fix omitting signal emission when customized text parts change the text.

diff --git a/NEWS b/NEWS
index 8c83859..590a652 100644 (file)
--- a/NEWS
+++ b/NEWS
@@ -118,6 +118,7 @@ Fixes:
    * Fix the bug which the callbacks of the sub-object are added even if the sub-object is added the parent object.
    * Fix the usage of the checks in the fileselector test 2.
    * Added the min_year and max_year in the standard profile config.
+   * Fix omitting signal emission when customized text parts change the text.
 
 Removals:
 

diff --git a/src/lib/elc_naviframe.c b/src/lib/elc_naviframe.c
index c7b5cf2..cbe0ab0 100644 (file)
--- a/src/lib/elc_naviframe.c
+++ b/src/lib/elc_naviframe.c
@@ -396,12 +396,12 @@ _item_text_set_hook(Elm_Object_Item *it,
              eina_stringshare_replace(&pair->part, part);
              nit->text_list = eina_inlist_append(nit->text_list,
                                                  EINA_INLIST_GET(pair));
-             if (label)
-               snprintf(buf, sizeof(buf), "elm,state,%s,show", part);
-             else
-               snprintf(buf, sizeof(buf), "elm,state,%s,hide", part);
-             elm_object_signal_emit(VIEW(it), buf, "elm");
           }
+        if (label)
+          snprintf(buf, sizeof(buf), "elm,state,%s,show", part);
+        else
+          snprintf(buf, sizeof(buf), "elm,state,%s,hide", part);
+        elm_object_signal_emit(VIEW(it), buf, "elm");
         elm_object_part_text_set(VIEW(it), part, label);
      }