rtlwifi: rtl8192cu: Fix memset/memcpy using sizeof(ptr) not sizeof(*ptr)
authorJoe Perches <joe@perches.com>
Mon, 9 May 2011 19:51:57 +0000 (12:51 -0700)
committerJohn W. Linville <linville@tuxdriver.com>
Tue, 10 May 2011 19:54:51 +0000 (15:54 -0400)
Found via coccinelle script

@@
type T;
T* ptr;
expression E1;
@@
* memset(E1, 0, sizeof(ptr));

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/rtlwifi/rtl8192cu/trx.c

index 79c98f6..3a92ba3 100644 (file)
@@ -372,7 +372,7 @@ static void _rtl_rx_process(struct ieee80211_hw *hw, struct sk_buff *skb)
        __le16 fc;
        struct ieee80211_hdr *hdr;
 
-       memset(rx_status, 0, sizeof(rx_status));
+       memset(rx_status, 0, sizeof(*rx_status));
        rxdesc  = skb->data;
        skb_len = skb->len;
        drvinfo_len = (GET_RX_DESC_DRVINFO_SIZE(rxdesc) * RTL_RX_DRV_INFO_UNIT);
@@ -434,7 +434,7 @@ static void _rtl_rx_process(struct ieee80211_hw *hw, struct sk_buff *skb)
                 "0x%02X\n", fc, (u32)hdr->addr1[0], (u32)hdr->addr1[1],
                 (u32)hdr->addr1[2], (u32)hdr->addr1[3], (u32)hdr->addr1[4],
                 (u32)hdr->addr1[5]));
-       memcpy(IEEE80211_SKB_RXCB(skb), &rx_status, sizeof(rx_status));
+       memcpy(IEEE80211_SKB_RXCB(skb), rx_status, sizeof(*rx_status));
        ieee80211_rx_irqsafe(hw, skb);
 }