dataurisrc: Fix crash when semicolon is aprt of data
authorBenjamin Otte <otte@redhat.com>
Tue, 21 May 2019 15:22:04 +0000 (17:22 +0200)
committerBenjamin Otte <otte@redhat.com>
Tue, 21 May 2019 15:22:04 +0000 (17:22 +0200)
This URI is valid:
  data:,;base64
(It encodes the literal string ";base64")

But would lead to a crash because the code assumed the semicolon would
be placed before the colon.

plugins/elements/gstdataurisrc.c

index 316966f..79521fa 100644 (file)
@@ -344,6 +344,9 @@ gst_data_uri_src_set_uri (GstURIHandler * handler, const gchar * uri,
   if (data_start == NULL)
     goto invalid_uri;
 
+  if (parameters_start > data_start)
+    parameters_start = NULL;
+
   if (data_start != uri && parameters_start != uri)
     mimetype =
         g_strndup (uri,