ASoC: SOF: ipc3: Log the tx message before sending it
authorPeter Ujfalusi <peter.ujfalusi@linux.intel.com>
Tue, 18 Oct 2022 13:38:43 +0000 (16:38 +0300)
committerMark Brown <broonie@kernel.org>
Tue, 18 Oct 2022 18:16:47 +0000 (19:16 +0100)
It makes more sense to log the message before it is sent to the DSP.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Link: https://lore.kernel.org/r/20221018133843.16958-1-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/ipc3.c

index b28af3a..1fef4dc 100644 (file)
@@ -329,6 +329,8 @@ static int ipc3_tx_msg_unlocked(struct snd_sof_ipc *ipc,
        struct snd_sof_dev *sdev = ipc->sdev;
        int ret;
 
+       ipc3_log_header(sdev->dev, "ipc tx", hdr->cmd);
+
        ret = sof_ipc_send_msg(sdev, msg_data, msg_bytes, reply_bytes);
 
        if (ret) {
@@ -338,8 +340,6 @@ static int ipc3_tx_msg_unlocked(struct snd_sof_ipc *ipc,
                return ret;
        }
 
-       ipc3_log_header(sdev->dev, "ipc tx", hdr->cmd);
-
        /* now wait for completion */
        return ipc3_wait_tx_done(ipc, reply_data);
 }