Fix ReqTypeToString()

Changes:
 * Add to missing comma
 * Change return type to char*

Change-Id: I775a732456d80d14c557b64cda54f841f8138d1d
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>

diff --git a/src/common/request_type.cc b/src/common/request_type.cc
index ae960d2..d5401fb 100644 (file)
--- a/src/common/request_type.cc
+++ b/src/common/request_type.cc
@@ -18,9 +18,9 @@
 
 namespace pkgmgr_common {
 
-const std::string& ReqTypeToString(ReqType type) {
-  static std::string convertArray[] = {
-      "GET_PKG_INFO"
+const char* ReqTypeToString(ReqType type) {
+  static const char* convertArray[] = {
+      "GET_PKG_INFO",
       "GET_APP_INFO",
       "SET_PKG_INFO",
       "SET_CERT_INFO",

diff --git a/src/common/request_type.hh b/src/common/request_type.hh
index 2d6a4e7..d528120 100644 (file)
--- a/src/common/request_type.hh
+++ b/src/common/request_type.hh
@@ -38,7 +38,7 @@ enum ReqType {
   MAX
 };
 
-EXPORT_API const std::string& ReqTypeToString(ReqType type);
+EXPORT_API const char* ReqTypeToString(ReqType type);
 
 }  // namespace pkgmgr_common
 

diff --git a/src/server/worker_thread.cc b/src/server/worker_thread.cc
index 5cb648f..bcd97d9 100644 (file)
--- a/src/server/worker_thread.cc
+++ b/src/server/worker_thread.cc
@@ -104,7 +104,7 @@ void WorkerThread::Run() {
     }
     pkgmgr_common::ReqType type = req->GetRequestType();
     LOGD("Request type(%s), pid(%d)",
-        pkgmgr_common::ReqTypeToString(type).c_str(), req->GetSenderPID());
+        pkgmgr_common::ReqTypeToString(type), req->GetSenderPID());
     if (type <= pkgmgr_common::ReqType::REQ_TYPE_NONE
             || type >= pkgmgr_common::ReqType::MAX) {
       LOGE("Request type is invalid (%d)", static_cast<int>(type));