i2c: imx: : use proper DMAENGINE API for termination
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Wed, 23 Jun 2021 09:59:36 +0000 (11:59 +0200)
committerWolfram Sang <wsa@kernel.org>
Wed, 11 Aug 2021 13:15:30 +0000 (15:15 +0200)
dmaengine_terminate_all() is deprecated in favor of explicitly saying if
it should be sync or async. Here, we want dmaengine_terminate_sync()
because there is no other synchronization code in the driver to handle
an async case.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
drivers/i2c/busses/i2c-imx.c

index d5b5f08..3576b63 100644 (file)
@@ -423,7 +423,7 @@ static int i2c_imx_dma_xfer(struct imx_i2c_struct *i2c_imx,
        return 0;
 
 err_submit:
-       dmaengine_terminate_all(dma->chan_using);
+       dmaengine_terminate_sync(dma->chan_using);
 err_desc:
        dma_unmap_single(chan_dev, dma->dma_buf,
                        dma->dma_len, dma->dma_data_dir);
@@ -894,7 +894,7 @@ static int i2c_imx_dma_write(struct imx_i2c_struct *i2c_imx,
                                &i2c_imx->dma->cmd_complete,
                                msecs_to_jiffies(DMA_TIMEOUT));
        if (time_left == 0) {
-               dmaengine_terminate_all(dma->chan_using);
+               dmaengine_terminate_sync(dma->chan_using);
                return -ETIMEDOUT;
        }
 
@@ -949,7 +949,7 @@ static int i2c_imx_dma_read(struct imx_i2c_struct *i2c_imx,
                                &i2c_imx->dma->cmd_complete,
                                msecs_to_jiffies(DMA_TIMEOUT));
        if (time_left == 0) {
-               dmaengine_terminate_all(dma->chan_using);
+               dmaengine_terminate_sync(dma->chan_using);
                return -ETIMEDOUT;
        }