rtc: r9701: stop setting a default time
authorAlexandre Belloni <alexandre.belloni@bootlin.com>
Thu, 15 Oct 2020 19:11:31 +0000 (21:11 +0200)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Mon, 19 Oct 2020 20:48:55 +0000 (22:48 +0200)
It doesn't make sense to set the RTC to a default value at probe time. Let
the core handle invalid date and time.

Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/20201015191135.471249-2-alexandre.belloni@bootlin.com
drivers/rtc/rtc-r9701.c

index eb00879..f8f7044 100644 (file)
@@ -115,7 +115,6 @@ static const struct rtc_class_ops r9701_rtc_ops = {
 static int r9701_probe(struct spi_device *spi)
 {
        struct rtc_device *rtc;
-       struct rtc_time dt;
        unsigned char tmp;
        int res;
 
@@ -126,27 +125,6 @@ static int r9701_probe(struct spi_device *spi)
                return -ENODEV;
        }
 
-       /*
-        * The device seems to be present. Now check if the registers
-        * contain invalid values. If so, try to write a default date:
-        * 2000/1/1 00:00:00
-        */
-       if (r9701_get_datetime(&spi->dev, &dt)) {
-               dev_info(&spi->dev, "trying to repair invalid date/time\n");
-               dt.tm_sec  = 0;
-               dt.tm_min  = 0;
-               dt.tm_hour = 0;
-               dt.tm_mday = 1;
-               dt.tm_mon  = 0;
-               dt.tm_year = 100;
-
-               if (r9701_set_datetime(&spi->dev, &dt) ||
-                               r9701_get_datetime(&spi->dev, &dt)) {
-                       dev_err(&spi->dev, "cannot repair RTC register\n");
-                       return -ENODEV;
-               }
-       }
-
        rtc = devm_rtc_device_register(&spi->dev, "r9701",
                                &r9701_rtc_ops, THIS_MODULE);
        if (IS_ERR(rtc))