media: atomisp: Remove yuvpp_mode
authorHans de Goede <hdegoede@redhat.com>
Tue, 21 Feb 2023 14:59:05 +0000 (14:59 +0000)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Sat, 15 Apr 2023 09:25:18 +0000 (10:25 +0100)
yuvpp_mode is never set, so it always is false remove it.

Link: https://lore.kernel.org/r/20230221145906.8113-10-hdegoede@redhat.com
Reviewed-by: Andy Shevchenko <andy@kernel.org>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/staging/media/atomisp/pci/atomisp_cmd.c
drivers/staging/media/atomisp/pci/atomisp_compat_css20.c
drivers/staging/media/atomisp/pci/atomisp_fops.c
drivers/staging/media/atomisp/pci/atomisp_subdev.h

index b102141..6645ee5 100644 (file)
@@ -4813,7 +4813,6 @@ int atomisp_set_fmt(struct video_device *vdev, struct v4l2_format *f)
        atomisp_csi_lane_config(isp);
 
        atomisp_check_copy_mode(asd, source_pad, &backup_fmt);
-       asd->yuvpp_mode = false;                        /* Reset variable */
 
        isp_sink_crop = *atomisp_subdev_get_rect(&asd->subdev, NULL,
                        V4L2_SUBDEV_FORMAT_ACTIVE,
index 9bfc9d0..d998719 100644 (file)
@@ -2445,8 +2445,6 @@ static unsigned int atomisp_get_pipe_index(struct atomisp_sub_device *asd,
 
        switch (source_pad) {
        case ATOMISP_SUBDEV_PAD_SOURCE_VIDEO:
-               if (asd->yuvpp_mode)
-                       return IA_CSS_PIPE_ID_YUVPP;
                if (asd->copy_mode)
                        return IA_CSS_PIPE_ID_COPY;
                if (asd->run_mode->val == ATOMISP_RUN_MODE_VIDEO
@@ -2465,8 +2463,6 @@ static unsigned int atomisp_get_pipe_index(struct atomisp_sub_device *asd,
                }
                fallthrough;
        case ATOMISP_SUBDEV_PAD_SOURCE_PREVIEW:
-               if (asd->yuvpp_mode)
-                       return IA_CSS_PIPE_ID_YUVPP;
                if (asd->copy_mode)
                        return IA_CSS_PIPE_ID_COPY;
                if (asd->run_mode->val == ATOMISP_RUN_MODE_VIDEO)
index 5ba5739..d8d4c41 100644 (file)
@@ -399,15 +399,6 @@ int atomisp_qbuffers_to_css(struct atomisp_sub_device *asd)
                css_video_pipe_id = IA_CSS_PIPE_ID_COPY;
        }
 
-       if (asd->yuvpp_mode) {
-               capture_pipe = &asd->video_out_capture;
-               video_pipe   = &asd->video_out_video_capture;
-               preview_pipe = &asd->video_out_preview;
-               css_capture_pipe_id = IA_CSS_PIPE_ID_COPY;
-               css_video_pipe_id   = IA_CSS_PIPE_ID_YUVPP;
-               css_preview_pipe_id = IA_CSS_PIPE_ID_YUVPP;
-       }
-
        if (capture_pipe) {
                buf_type = atomisp_get_css_buf_type(
                               asd, css_capture_pipe_id,
@@ -583,7 +574,6 @@ static void atomisp_subdev_init_struct(struct atomisp_sub_device *asd)
 
        asd->mipi_frame_size = 0;
        asd->copy_mode = false;
-       asd->yuvpp_mode = false;
 
        asd->stream_prepared = false;
        asd->high_speed_mode = false;
index 5583d6a..df6e2a8 100644 (file)
@@ -330,7 +330,6 @@ struct atomisp_sub_device {
        unsigned int mipi_frame_size;
 
        bool copy_mode; /* CSI2+ use copy mode */
-       bool yuvpp_mode;        /* CSI2+ yuvpp pipe */
 
        int raw_buffer_bitmap[ATOMISP_MAX_EXP_ID / 32 +
                                                 1]; /* Record each Raw Buffer lock status */