drm/panfrost: Prefix interrupt handlers' names
authorEzequiel Garcia <ezequiel@collabora.com>
Sat, 14 Dec 2019 04:59:52 +0000 (01:59 -0300)
committerRob Herring <robh@kernel.org>
Tue, 21 Jan 2020 16:30:10 +0000 (10:30 -0600)
Currently, the interrupt lines requested by Panfrost
use unmeaningful names, which adds some obscurity
to interrupt introspection (i.e. any tool based
on procfs' interrupts file).

In order to improve this, prefix each requested
interrupt with the module name: panfrost-{gpu,job,mmu}.

Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
Reviewed-by: Steven Price <steven.price@arm.com>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20191214045952.9452-1-ezequiel@collabora.com
drivers/gpu/drm/panfrost/panfrost_gpu.c
drivers/gpu/drm/panfrost/panfrost_job.c
drivers/gpu/drm/panfrost/panfrost_mmu.c

index 460fc19..1b9b79c 100644 (file)
@@ -346,7 +346,7 @@ int panfrost_gpu_init(struct panfrost_device *pfdev)
                return -ENODEV;
 
        err = devm_request_irq(pfdev->dev, irq, panfrost_gpu_irq_handler,
-                              IRQF_SHARED, "gpu", pfdev);
+                              IRQF_SHARED, KBUILD_MODNAME "-gpu", pfdev);
        if (err) {
                dev_err(pfdev->dev, "failed to request gpu irq");
                return err;
index d411eb6..f68ad9d 100644 (file)
@@ -496,7 +496,7 @@ int panfrost_job_init(struct panfrost_device *pfdev)
                return -ENODEV;
 
        ret = devm_request_irq(pfdev->dev, irq, panfrost_job_irq_handler,
-                              IRQF_SHARED, "job", pfdev);
+                              IRQF_SHARED, KBUILD_MODNAME "-job", pfdev);
        if (ret) {
                dev_err(pfdev->dev, "failed to request job irq");
                return ret;
index a3ed64a..d369457 100644 (file)
@@ -632,9 +632,11 @@ int panfrost_mmu_init(struct panfrost_device *pfdev)
        if (irq <= 0)
                return -ENODEV;
 
-       err = devm_request_threaded_irq(pfdev->dev, irq, panfrost_mmu_irq_handler,
+       err = devm_request_threaded_irq(pfdev->dev, irq,
+                                       panfrost_mmu_irq_handler,
                                        panfrost_mmu_irq_handler_thread,
-                                       IRQF_SHARED, "mmu", pfdev);
+                                       IRQF_SHARED, KBUILD_MODNAME "-mmu",
+                                       pfdev);
 
        if (err) {
                dev_err(pfdev->dev, "failed to request mmu irq");